822389 - [homescreen] Moving icons in broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Seen on git/gecko-18 branch.

STR:
1. From homescreen, tap and hold on (e.g. the camera) icon to start throbbing
2. Try to drag camera icon to the ribbon at the bottom

Expected: should be able to add camera icon to the ribbon

Observed: ribbon does not accept camera icon; when drag is released, camera icon appears somewhere else randomly on the homescreen; tapping the home button causes the icon to reappear in its original place, bug leaves the newly/randomly-appeared icon on the screen as well.

This looks a lot like what I was seeing in bug 813258.

Comment 1

[isabelrios]

Attachment: duplicated icon on homescreen

Comment 2

[isabelrios]

Reproduced while running the smoke test: 
Gaia 2b77f0
Gecko 2aa138d
Please see attached screenshot. It is necessary to reboot the device to make the duplicate icons dissapear.
To reproduce it easily, long press on an icon, move it on another one, keep it there for a while and then stop pressing on it. It is then duplicated

Comment 3

[Dylan Oliver [:doliver]]

Symptoms are similar to bug 813258.

Comment 4

[Cristian Rodriguez (:crdlc)]

Gaia a0ecffc.tgz
Gecko 5bad6f1

I've installed the last version of gecko 12-19-12 and Gaia and I cannot reproduce the problem. Although I realized that the transitions are less smooth with latest builds of Gecko and as far as I know nobody change nothing in the drag&drop algorithm.

Comment 5

[Cristian Rodriguez (:crdlc)]

And this one is not related to bug 813258 because in that case there was a bug in Gaia and now is related to Gecko IMHO

Comment 7

[Cristian Rodriguez (:crdlc)]

Hi Vivien, what do you think about my comments? thanks

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

I agree with crdlc and think we should close this. I can't reproduce with the latest b2g-beta Gecko and Gaia. Not sure what solved this but it was definitely reproducible for me yesterday.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

That's another victim of bug 814252. After backing out the back out I could reproduce this again.

Comment 10

[Cristian Rodriguez (:crdlc)]

Isabel, please, can you reproduce it with development build today?

Comment 11

[Cristian Rodriguez (:crdlc)]

In production build the 'animationend' event is not fired

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/page.js#L558

Comment 12

[isabelrios]

Cristian, I cannot reproduced it with the development build but it happens with the production one.

Comment 13

[Cristian Rodriguez (:crdlc)]

Mayday :) Now I can reproduce it in the latest development build (c75c560).

Problem:

The 'animationend' event is not fired:

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/page.js#L558

Comment 15

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

This bug is still reproducible even after bug 814252 been backout. So, this bug is not a regression of bug 814252.

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

(In reply to crdlc from comment #11)
> In production build the 'animationend' event is not fired

Hmmm. That reminds me of bug 822392. Can you try applying the patches from bug 822231 and see if that fixes this bug?

Comment 17

[Cristian Rodriguez (:crdlc)]

in a couple of hours

Comment 18

[Tim Taubert [:ttaubert] (inactive)]

Yep, it's gonna be fixed by bug 822231, just tried it locally.

Comment 19

[Cristian Rodriguez (:crdlc)]

what is the idea behind that patch?. I am testing on home but it doesn't work for me :( I could be implementing wrong the idea...

Comment 20

[Tim Taubert [:ttaubert] (inactive)]

You need to apply both patches from bug 822231, build Gecko and then check again.

Comment 21

[Cristian Rodriguez (:crdlc)]

umm I understand but I cannot build Gecko... waiting for bug 822231

Comment 22

[Dylan Oliver [:doliver]]

It looks like this one is working again after bug 822231 -- any further work required here?

Comment 23

[Jason Smith [:jsmith]]

(In reply to Dylan Oliver [:doliver] from comment #22)
> It looks like this one is working again after bug 822231 -- any further work
> required here?

Did you confirm this works now on a latest build with that patch? If so, then yeah, let's close this as fixed.

Comment 24

[Tim Guan-tin Chien [:timdream] (please needinfo)]

It's fixed I think, I cannot no longer reproduce this with comment 0 STR

Comment 25

[Jason Smith [:jsmith]]

Closing per comment 24.

Comment 26

[u279076]

Software: Boot2Gecko 1.0.0-prerelease
Platform: 18.0
Build ID: 20130110070201

I can't reproduce this bug with this build using the details in comment 0. Marking this bug verified fixed.