822422 - Firefox wordmark barely visible on dark lightweight themes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

The Firefox wordmark is barely visible on dark lightweight themes. We need different set of resources that would work on light and dark themes (in addition to default one).

Comment 1

[Ian Barlow (:ibarlow)]

We'll need a white Firefox wordmark for this. CC-ing Eric.

Comment 2

[Eric Pang [:epang] UX]

Attachment: White Firefox Watermark

Sized for mdpi, hdpi and xhdpi.  let me know if anything else is needed, thx!

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

White on dark. Black on light. All good. :D

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9cef5f38fe1

Comment 5

[Ed Morley [:emorley]]

Push backed out for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=18097340&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/850b6458a7f0

Please try building locally before pushing! :-)

Comment 6

[Sriram Ramasubramanian [:sriram]]

I had triggered a clobber for the same. It's a clobbering issue.

Comment 7

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51119e80e283

Comment 8

[Ed Morley [:emorley]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #6)
> I had triggered a clobber for the same. It's a clobbering issue.

Ah, sorry.

Our mobile build story is so messed up :-(

Comment 9

[Sriram Ramasubramanian [:sriram]]

Tried in try: https://tbpl.mozilla.org/?tree=Try&rev=d340eeb569ff

Comment 10

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ecc2913a1e6

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ecc2913a1e6

Comment 12

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 693636 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Personas.
User impact if declined: Firefox watermark will be in grey on a dark theme, and barely visible.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Very low. Just addition of few images in this patch.
String or UUID changes made by this patch: None.

Comment 13

[Ioana Chiorean]

Firefox 20.0a1 (20123-01-02)
Device: Galaxy Nexus 
OS: Android 4.1.1 

I can see the white wordmark using the theme : https://addons.mozilla.org/en-US/android/addon/a-festival-of-lights-pink-f/  Bug is verified on Nightly. Please push this to aurora and I will mark this verified after checking it on Firefox 19 too

Comment 14

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47cfe3f06afe

Comment 15

[Ioana Chiorean]

Firefox 19 Beta 1 (2013-01-08)
Device: Galaxy Nexus
OS:Android 4.1.

This was push in beta channel also as Firefox 19 is currently in Beta. As the wordmark is white now I will mark the bug Verified Fixed.