822430 - AddonRepository.jsm: test for equality (==) mistyped as assignment (=)?

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Daniel Holbert [:dholbert]]

This is spammed as a part of my debug build's normal running output now:
{
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1751
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1776
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1810
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1842
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1874
                     test for equality (==) mistyped as assignment (=)?
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

This adds an extra layer of parens, to indicate that the assignment-as-loop-condition is explicitly intentional. (as in Bug 821507)

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f578e6d37c13

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f578e6d37c13