Closed Bug 822430 Opened 7 years ago Closed 7 years ago

AddonRepository.jsm: test for equality (==) mistyped as assignment (=)?

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

This is spammed as a part of my debug build's normal running output now:
{
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1751
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1776
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1810
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1842
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/AddonRepository.jsm:1874
                     test for equality (==) mistyped as assignment (=)?
}
Summary: ddonRepository.jsm: test for equality (==) mistyped as assignment (=)? → AddonRepository.jsm: test for equality (==) mistyped as assignment (=)?
Attached patch fix v1Splinter Review
This adds an extra layer of parens, to indicate that the assignment-as-loop-condition is explicitly intentional. (as in Bug 821507)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #693074 - Flags: review?(dtownsend+bugmail)
Attachment #693074 - Flags: review?(dtownsend+bugmail) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f578e6d37c13
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/f578e6d37c13
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.