Closed Bug 822431 Opened 7 years ago Closed 7 years ago

MOZ_ASSERT should use MOZ_UNLIKELY

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23
Tracking Status
firefox22 --- wontfix
firefox23 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(1 file)

Not that these branches should be hard to predict, but we should hint as such anyways.
Attached patch patchSplinter Review
Assignee: nobody → jgilbert
Status: NEW → ASSIGNED
Attachment #693075 - Flags: review?(jwalden+bmo)
Comment on attachment 693075 [details] [diff] [review]
patch

Review of attachment 693075 [details] [diff] [review]:
-----------------------------------------------------------------

Add a mozilla/Likely.h #include to the top of the file -- this patch is totally depending on #include bootlegging right now.  I'm a bit surprised it even works, to be honest.  I guess we don't have enough tests that all headers work when used without anything else.  :-\
Attachment #693075 - Flags: review?(jwalden+bmo) → review+
OS: Windows 7 → All
Hardware: x86_64 → All
jglibert, do you still plan to land this r+'d patch for MOZ_ASSERT?
Flags: needinfo?(jgilbert)
It's in the pile, but anyone can land it so long as the also fix the nit Waldo mentioned.
Flags: needinfo?(jgilbert)
https://hg.mozilla.org/mozilla-central/rev/87ac8643d3b3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.