822448 - Data connection does not need to be reset when changing preferred network type

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[pgravel]

carrier.js currently turns the data connection off and then back on when the preferred network type changes (i.e. going from 2G to 3G). This is unnecessary as the data connection remains valid while changing preferred network types.

Current behavior:
- Preferred network type changes
- ril.data.enabled is set to false
- Data connection is torn down
- Modem switches from 2G to 3G
- After the 2.5 seconds timer expires, ril.data.enabled is set to true
- Data connection is reestablished.

Expected behavior:
- Preferred network type changes
- Modem switches from 2G to 3G
- Data connection remains alive and well.

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Phil has a patch for this and should share the details here today.  From what I've heard it's very minor

Comment 2

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 3

[pgravel]

Attachment 693915 [details] [diff] is exactly what is needed. As mentioned, it is a fairly trivial change.

Comment 4

[Evelyn Hung]

Comment on attachment 693915 [details] [diff] [review]
patch proposal

r=me, apparently good. Thanks.

Comment 5

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/046a40d2e3d629d27c23bd2cee5d39bd3132d922

Comment 7

[Jeni]

Verified fix in Build 20130103070201