822477 - [contacts] "Import SIM Contacts" incorrectly disabled if SIM card disabled on mobile network

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Repro:

1. Find an old SIM card that will no longer connect to the network it was made for, but has contacts on it.
2. Put SIM card in phone, boot
3. Go to Contacts -> Settings

Expected:

Import from SIM is enabled unless SIM is PIN/PUK locked

Actual:

Import from SIM is disabled

Notes:

The check in contacts/js/contacts_settings.js shows that we're checking the existence of mozMobileConnection (this should always work) and then checking whether the status of the card is "ready". mozMobileConnection says that the status can be null, 'absent', 'pinRequired', 'pukRequired', 'networkLocked', 'ready'. So apparently we're getting something other than ready back. If I kill the check for ready and always return true just to make the button come up, I can import my contacts from my SIM with no problems. 

Blocking Need:

People will possibly be changing SIMs for their new phone, at which point they may want to import from an old deactivated SIM, then swap the new SIM in.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Just put RIL in debug mode. The card state flips from null to ready then back to null. Trying to figure out why now.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Ok, the cardstate is flipping from READY to NOTREADY, which is translated as null. This means that we're treating the card as if it has an unknown error even when it just can't activate itself on the network. Creating a new bug for this since we're now into gecko territory, blocking this bug on it.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Another blocking reason: Blocks bb+ 822251

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Marking as tracked for v1.1

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Make Contact Import from SIM work even if SIM can't hit cellular network

This is the easy fix for the moment. The cardstate should only be null if there's a network exception, which means the card should still be ok to read from at least. If the card isn't even in, we'll get "absent" state.

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 695864 [details] [diff] [review]
Patch 1 (v1) - Make Contact Import from SIM work even if SIM can't hit cellular network

Review of attachment 695864 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks !

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 695864 [details] [diff] [review]
Patch 1 (v1) - Make Contact Import from SIM work even if SIM can't hit cellular network

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 8

[Julien Wajsberg [:julienw]]

Kyle, BTW, could you check if this bug happens in FTU as well ?

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 695864 [details] [diff] [review]
Patch 1 (v1) - Make Contact Import from SIM work even if SIM can't hit cellular network

Safe one liner that will let you use the sim import functionality even inside an elevator.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/c94217aaad7bc0283ee77e68559027a9da8e157f