822508 - Providers can't specify 'null' for the profile info when the user is logged out.

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: Allow null for the profile, plus tests

Via bug 821323.  If the provider finds the user is not logged out, they can't specify |null| as the profile, but must instead specify |{}|.

Allowing null is a trivial fix and makes the api cleaner.  It's even possible we already document |null| is acceptable.  The following patch fixes this and includes tests.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Nominating for aurora as this is a trivial fix and it would be a shame to tell new providers coming on board they should work around this.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 693180 [details] [diff] [review]
Allow null for the profile, plus tests

Assigning profile to profile looks like a bug at first glance, I'd probably put the null check first and avoid being too clever:

if (!profile)
  profile = {};
this.profile = profile;

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Actually, this isn't a regression, right? Given the lack of multi-provider on Aurora, seems like we probably actually don't need to land this there.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: As landed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/57adbfadcc85

Comment 5

[Mark Hammond [:markh] [:mhammond]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #3)
> Actually, this isn't a regression, right? Given the lack of multi-provider
> on Aurora, seems like we probably actually don't need to land this there.

Yep, fair enough - removing tracking flag for 19.

Comment 6

[Shane Caraveo (:mixedpuppy)]

not objecting to the change, but we do already have providers developing against 17+.  Docs should get updated.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/57adbfadcc85