822596 - Stop using Google calendar schedules in TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

* The sheriff schdule isn't used (and we've not going to be using the sheriffing site any time soon), causing confusion.
* It causes bug 764801 on Opera.
* It often causes TBPL to fail to load correctly, when Google is having a bad day (bug 821363 and more that were never filed since transient).

The above have been driving me nuts for months and yet again today TBPL is misbehaving due to Google calendar issues:

[11:24:29.596] SyntaxError: test for equality (==) mistyped as assignment (=)? @ https://www.google.com/uds/api/gdata/1.10/208a907929e7936990d2bf48205aa8d8/core,mediarss,opensearch,geo,atom,threading,app,gdata,maps,gbase,finance,blogger,contacts,analytics,acl,calendar,default.I.js:12
[11:24:29.597] SyntaxError: test for equality (==) mistyped as assignment (=)? @ https://www.google.com/uds/api/gdata/1.10/208a907929e7936990d2bf48205aa8d8/core,mediarss,opensearch,geo,atom,threading,app,gdata,maps,gbase,finance,blogger,contacts,analytics,acl,calendar,default.I.js:23
[11:24:29.597] SyntaxError: test for equality (==) mistyped as assignment (=)? @ https://www.google.com/uds/api/gdata/1.10/208a907929e7936990d2bf48205aa8d8/core,mediarss,opensearch,geo,atom,threading,app,gdata,maps,gbase,finance,blogger,contacts,analytics,acl,calendar,default.I.js:39
[11:24:29.598] SyntaxError: test for equality (==) mistyped as assignment (=)? @ https://www.google.com/uds/api/gdata/1.10/208a907929e7936990d2bf48205aa8d8/core,mediarss,opensearch,geo,atom,threading,app,gdata,maps,gbase,finance,blogger,contacts,analytics,acl,calendar,default.I.js:63
[11:24:29.599] SyntaxError: test for equality (==) mistyped as assignment (=)? @ https://www.google.com/uds/api/gdata/1.10/208a907929e7936990d2bf48205aa8d8/core,mediarss,opensearch,geo,atom,threading,app,gdata,maps,gbase,finance,blogger,contacts,analytics,acl,calendar,default.I.js:97

We should just strip out the Google calendar integration for now and for the buildduty schedule, just link to the Google calendar.

Comment 1

[Ed Morley [:emorley]]

Attachment: Part 1: s/staticSheriff/sheriff

(Since you indicated you might be interested in working on TBPL once it was in it's own repo... :P)

If we're not using the calendar, 'staticSheriff' is no longer accurate, since they'll all be static.

Comment 2

[Ed Morley [:emorley]]

Attachment: Part 2: Don't embed buildduty calendar, just link to it

Comment 3

[Ed Morley [:emorley]]

Attachment: Part 3: Move where we generate the custom sheriff text

We have no need to generate it in the same block that sets the tree open/closed/approval required status; no idea why it was put there.

Comment 4

[Ed Morley [:emorley]]

Attachment: Part 4: Stop using defunct sheriff calendar

...instead list #developers unless custom sheriff text specified for that tree in Config.js

This and patch part 2 were the last consumers of the calendar code (and thus the Google jsapi include).

Comment 5

[Ed Morley [:emorley]]

Attachment: Part 5: Specify custom sheriff for more trees

Comment 7

[Jeff Hammel]

Comment on attachment 693349 [details] [diff] [review]
Part 2: Don't embed buildduty calendar, just link to it

seems a lot safer

Comment 8

[Jeff Hammel]

(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #3)
> Created attachment 693352 [details] [diff] [review]
> Part 3: Move where we generate the custom sheriff text
> 
> We have no need to generate it in the same block that sets the tree
> open/closed/approval required status; no idea why it was put there.

Probably convenience at the time ;)

Comment 9

[Jeff Hammel]

Comment on attachment 693353 [details] [diff] [review]
Part 4: Stop using defunct sheriff calendar

again, seems a lot safer :) I love code removal

Comment 10

[Jeff Hammel]

Comment on attachment 693354 [details] [diff] [review]
Part 5: Specify custom sheriff for more trees

lgtm

Comment 11

[Ed Morley [:emorley]]

Thank you for the reviews :-)

https://hg.mozilla.org/webtools/tbpl/rev/c3e8b9d5a88b
https://hg.mozilla.org/webtools/tbpl/rev/71b470fb5dd9
https://hg.mozilla.org/webtools/tbpl/rev/7f8399e896db
https://hg.mozilla.org/webtools/tbpl/rev/8bdec10c2ca9
https://hg.mozilla.org/webtools/tbpl/rev/8c09f46f3d7e

Comment 12

[Ed Morley [:emorley]]

In production.