822609 - developer tools should not use target.isChrome [toolbox]

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Comment 1

[Joe Walker [:jwalker]]

target.isChrome is always false, so it's easy to remove.

Comment 2

[Joe Walker [:jwalker]]

Attachment: v1

This is a quick 'before I forget'

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 693319 [details] [diff] [review]
v1

In these 2 cases, what we want to use is `this._target.isLocalTab`. Also, while you're at it, in `_getHostTab`, if it's not a tab target, we should not return the selected tab, but throw an exception (this should never happen. window and remote tab can't have HostTab).

Comment 4

[Joe Walker [:jwalker]]

I know we have batted this around a lot, but I'm not sure that isLocalTab is right yet. Is the question that we want to ask really - "Is this something that a typical web user might want to debug?"
Isn't this is a concept that we're missing from remote connections?

I'm not going to fix it here, but maybe we need isSystem or similar to reflect the concept of 'not for typical users'.

Comment 5

[Joe Walker [:jwalker]]

Attachment: v2

So I went further and removed _getHostTab. Also I added the profiler to the list of things that needed updating.

Comment 6

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=c8964d4d1a96

Comment 7

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=a2754cd8e66b
https://hg.mozilla.org/integration/fx-team/rev/2767d63a3b15

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/2767d63a3b15