822628 - Does not remember analogical/digital display after closing the clock.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Nicolas B. Pierron [:nbp] {away}]

Device:
 Version 1.0.0
 Platform 18.0
 Build id 20121206062128

STR:
- Open the clock
- tap on the clock
* The display switch from analogical to digital
- Press Home
- Swipe up the clock app to close
- Open the clock

Observed:
The outdated screenshot showing the digital clock is shown and is replaced by the analogical clock.

Expected:
The digital clock is shown (screenshot) and updated as soon as the app finish restarting.

Comment 1

[[e-mail], [e-mail]]

I think it's not a blocking issue. But we can remember user's latest display mode in the indexedDB.

Comment 2

[John Shih]

agree with Ian, this is a polish but also making sense to remember the latest mode since we have mode switching functionality 
Ian, can you ask for approving on this?

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Here's a patch: https://github.com/mozilla-b2g/gaia/pull/7708

Comment 4

[[e-mail], [e-mail]]

(In reply to janjongboom from comment #3)
> Here's a patch: https://github.com/mozilla-b2g/gaia/pull/7708

Hi Jan,

Thanks for your help. And I quickly review your patch with some comment on github.

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch for this issue

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 706280 [details] [diff] [review]
Patch for this issue

Jan,
Since you revised all comments according my suggestion, the patch works for me.
r=me

Thanks for your help.
Nice job!

Comment 7

[[e-mail], [e-mail]]

Jan,
Since the pr(https://github.com/mozilla-b2g/gaia/pull/7708) is merged, you can close the issue.
Thanks.

Comment 8

[Askeing Yen[:askeing][:fyen]]

Device unagi
gaia   122ee16093d9730de7a9c6beba989adeb5d716ae
gecko  95bf443385bbd8ee611be1586ec975e609acd006

Verified.