822634 - [communitations] Possible CSP problems

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia, defect)

Description

[Carmen Jimenez Cabezas]

I've passed a static analysis on the source code of Gaia looking for possible problems regarding the default CSP. The communications application has the following possible issues:

FILE: shared/style/edit_mode/index.html
30:  <form role="dialog" data-type="edit" onsubmit="return false;">

FILE: shared/style/action_menu/index.html
27:  <form role="dialog" data-type="action" onsubmit="return false;">

FILE: index.html
238:                    <a href="javascript: void(0);" class="action action-block">

FILE: oauth2/flow.html
19:    <script>

FILE: oauth2/dialogs_end.html
20:    <script>

FILE: style/edit_mode/index.html
30:  <form role="dialog" data-type="edit" onsubmit="return false;">

FILE: style/action_menu/index.html
27:  <form role="dialog" data-type="action" onsubmit="return false;">

Comment 1

[Kevin Grandon :kgrandon]

I believe the majority of these were fixed at some point. Most line numbers don't match up anymore. Please re-open with updated line-numbers if this is still an issue.