822638 - [sms] Possible CSP problem

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Carmen Jimenez Cabezas]

I've passed a static analysis on the source code of Gaia looking for possible problems regarding the default CSP. The sms application has the following possible issue:

FILE: shared/style/edit_mode/index.html
30:  <form role="dialog" data-type="edit" onsubmit="return false;">

Comment 1

[Borja Salguero [:borjasalguero]]

This one is related with building blocks, and comes from 'shared/style/edit_mode/index.html', but this is an 'example' html so the APP should be working as expected. However, it should be nice to fix this even in our examples.

Comment 2

[Borja Salguero [:borjasalguero]]

Attachment: PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 3

[Borja Salguero [:borjasalguero]]

I've removed the 'obsubmit' because this it's only an example of use of the BB, and it's not related with SMS App at all.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 700469 [details]
PR

Simple harmless change in the dom, but fixes a CSP issue so a=me

Thanks Borja.

Comment 5

[Borja Salguero [:borjasalguero]]

Merged! Closing.