builds use the wrong version of perl

RESOLVED FIXED in 3.11.7

Status

NSS
Build
P2
minor
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: cls, Assigned: Neil Williams)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

11.17 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Christophe Ravel
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
security/nss/lib/ckfw/builtins/Makefile has a hardcoded reference to perl which
assumes that perl is in your path and that it's perl 5.

Bismark tinderbox log:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/990573960.3814.gz

Comment 1

16 years ago
Created attachment 35751 [details] [diff] [review]
Proposed patch.

Comment 2

16 years ago
The proposed patch added a new makefile target 'generate'
that generates the certdata.c file with the Perl script.
So perl won't be invoked by default.

Ian, this means when you add a new root cert to certdata.txt,
you will need to say 'make generate' to generate a new
certdata.c.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 3.2.2
Version: 3.2.2 → 3.2.1
(Reporter)

Comment 3

16 years ago
Ok, that seems like the entirely wrong fix for the problem and doesn't address
the other uses of perl in coreconf/*.mk .  Granted, I don't know if those other
instances are referenced but what's wrong with using a PERL variable that we can
override?   

There's also hardcoded references to zip & gzip that should be addressed.
Summary: NSS uses hardcoded perl → NSS uses hardcoded values in commands

Updated

16 years ago
Severity: blocker → minor
Target Milestone: 3.2.2 → 3.4

Updated

16 years ago
Component: Libraries → Build

Comment 4

16 years ago
Lowered priority to P2.
Priority: P1 → P2

Comment 5

15 years ago
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee

Comment 6

15 years ago
Set target milestone to NSS 3.5.
Target Milestone: 3.4 → 3.5

Updated

15 years ago
Target Milestone: 3.5 → Future

Comment 7

15 years ago
*** Bug 102326 has been marked as a duplicate of this bug. ***

Comment 8

15 years ago
We should also handle the case of zip being used to
generate jar files.  The jar command can be used for
that purpose.

Updated

15 years ago
OS: Solaris → All
Hardware: Sun → All
(Reporter)

Comment 9

14 years ago
Created attachment 141685 [details] [diff] [review]
Use PERL

This patch takes care of the perl issue by setting PERL in coreconf/command.mk
and using it in coreconf/rules.mk and the other Makefiles.  Mozilla builds will
override PERL with the one detected by configure when building.  This patch was
needed to deal with the issue from bug 234088.
Attachment #35751 - Attachment is obsolete: true
(Reporter)

Updated

14 years ago
Attachment #141685 - Flags: review?(wchang0222)
QA Contact: bishakhabanerjee → jason.m.reid
Assignee: wtchang → christophe.ravel.bugs
Status: ASSIGNED → NEW
Target Milestone: Future → ---
Comment on attachment 141685 [details] [diff] [review]
Use PERL

Neil, please review this patch and see if it still applies, and if it works.  
Thanks.
Attachment #141685 - Flags: review?(neil.williams)
QA Contact: jason.m.reid → build
(Assignee)

Comment 11

11 years ago
Comment on attachment 141685 [details] [diff] [review]
Use PERL

This patch does not apply cleanly to the NSS 3.11 branch. Since bug 234088 has been marked as WONTFIX (because it's not necessary to fix) we can probably do the same with this one
Attachment #141685 - Flags: review?(neil.williams) → review-
(Reporter)

Comment 12

11 years ago
Bug 234088 is about running against the wrong version of perl when running the scripts outside of the build system.  This bug involves running against the wrong version of perl (& other commands) when running the scripts from within the build system.
I agree this is worthy of fixing.  

Neil and Christophe, how difficult is it to update this patch to apply to 
the 3.11 branch and trunk?
Summary: NSS uses hardcoded values in commands → builds use the wrong version of perl
Target Milestone: --- → 3.11.1
(Reporter)

Comment 14

11 years ago
Created attachment 217260 [details] [diff] [review]
updated against NSS_311_BRANCH
Attachment #141685 - Attachment is obsolete: true
Attachment #141685 - Flags: review?(wtchang)
Comment on attachment 217260 [details] [diff] [review]
updated against NSS_311_BRANCH

Christophe, please test this patch on one of our nightly builds, using your patch testing facility.

Comment 16

11 years ago
Last night build on NSS_3_11_BRANCH ran with this patch applied. I didn't see any build issue on all platforms we support at Sun.
Comment on attachment 217260 [details] [diff] [review]
updated against NSS_311_BRANCH

Neil please reivew.  Also, please check and see if thie patch applies cleanly to the trunk.
Attachment #217260 - Flags: review?(neil.williams)
(Assignee)

Comment 18

11 years ago
Comment on attachment 217260 [details] [diff] [review]
updated against NSS_311_BRANCH

This patch changes most of the perl references that were missed in the first patch. There are that don't seem to be covered by this patch. What about lib/ckfw/builtins/Makefile and lib/ckfw/nssmkey/Makefile?
No need to change them because they are not normally built?
Attachment #217260 - Flags: review?(neil.williams) → review+
(Reporter)

Comment 19

11 years ago
I just missed those references (not sure how).  They should be fixed as well. 

Comment 20

11 years ago
neil.williams@sun.com: can you just fix them and commit, or do we need to spend time on another patch cycle?
Assignee: christophe.ravel.bugs → neil.williams
(Assignee)

Updated

10 years ago
Target Milestone: 3.11.1 → 3.11.8
Comment on attachment 217260 [details] [diff] [review]
updated against NSS_311_BRANCH

Let's get this patch into 3.11.7 if possible
Attachment #217260 - Flags: review?(christophe.ravel.bugs)
Target Milestone: 3.11.8 → 3.11.7

Updated

10 years ago
Attachment #217260 - Flags: review?(christophe.ravel.bugs) → review+
(Assignee)

Comment 22

10 years ago
Created attachment 263818 [details] [diff] [review]
converted to current 3.11 branch

Had to make a new patch--for one thing there is no security/manager/Makefile any more.
Attachment #217260 - Attachment is obsolete: true
Attachment #263818 - Flags: review?(christophe.ravel.bugs)

Updated

10 years ago
Attachment #263818 - Flags: review?(christophe.ravel.bugs) → review+
(Assignee)

Comment 23

10 years ago
Comment on attachment 263818 [details] [diff] [review]
converted to current 3.11 branch

One more for branch.
Attachment #263818 - Flags: review?(nelson)
Comment on attachment 263818 [details] [diff] [review]
converted to current 3.11 branch

I have not reviewed all the makefiles for completeness of this patch, but it looks right as far as it goes.
Attachment #263818 - Flags: review?(nelson) → review+
(Assignee)

Comment 25

10 years ago
For 3.11.7.

Checking in coreconf/command.mk;
/cvsroot/mozilla/security/coreconf/command.mk,v  <--  command.mk
new revision: 1.8.2.1; previous revision: 1.8
done
Checking in coreconf/rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.66.2.6; previous revision: 1.66.2.5
done
Checking in nss/lib/ckfw/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/Makefile,v  <--  Makefile
new revision: 1.7.28.1; previous revision: 1.7
done
Checking in nss/lib/ckfw/builtins/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/Makefile,v  <--  Makefile
new revision: 1.16.2.1; previous revision: 1.16
done
Checking in nss/lib/ckfw/capi/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/Makefile,v  <--  Makefile
new revision: 1.2.2.1; previous revision: 1.2
done
Checking in nss/lib/freebl/ecl/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/ecl/Makefile,v  <--  Makefile
new revision: 1.2.28.2; previous revision: 1.2.28.1
done
Checking in nss/lib/freebl/mpi/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile,v  <--  Makefile
new revision: 1.22.2.2; previous revision: 1.22.2.1
done
Checking in nss/lib/freebl/mpi/Makefile.os2;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.os2,v  <--  Makefile.os2
new revision: 1.3.30.1; previous revision: 1.3
done
Checking in nss/lib/freebl/mpi/Makefile.win;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.win,v  <--  Makefile.win
new revision: 1.3.30.1; previous revision: 1.3
done
Checking in nss/lib/freebl/mpi/timetest;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/timetest,v  <--  timetest
new revision: 1.6.30.1; previous revision: 1.6
done
Checking in nss/lib/pki1/Makefile;
/cvsroot/mozilla/security/nss/lib/pki1/Makefile,v  <--  Makefile
new revision: 1.7.28.1; previous revision: 1.7
done

Includes one perl -> $(PERL) fix in lib/ckfw/builtins/Makefile that wasn't caught before.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 26

10 years ago
For trunk.

Checking in coreconf/command.mk;
/cvsroot/mozilla/security/coreconf/command.mk,v  <--  command.mk
new revision: 1.9; previous revision: 1.8
done
Checking in coreconf/rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.73; previous revision: 1.72
done
Checking in nss/lib/ckfw/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/Makefile,v  <--  Makefile
new revision: 1.11; previous revision: 1.10
done
Checking in nss/lib/ckfw/builtins/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/Makefile,v  <--  Makefile
new revision: 1.17; previous revision: 1.16
done
Checking in nss/lib/ckfw/capi/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/Makefile,v  <--  Makefile
new revision: 1.3; previous revision: 1.2
done
Checking in nss/lib/freebl/ecl/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/ecl/Makefile,v  <--  Makefile
new revision: 1.6; previous revision: 1.5
done
Checking in nss/lib/freebl/mpi/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile,v  <--  Makefile
new revision: 1.24; previous revision: 1.23
done
Checking in nss/lib/freebl/mpi/Makefile.os2;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.os2,v  <--  Makefile.os2
new revision: 1.4; previous revision: 1.3
done
Checking in nss/lib/freebl/mpi/Makefile.win;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.win,v  <--  Makefile.win
new revision: 1.4; previous revision: 1.3
done
Checking in nss/lib/freebl/mpi/timetest;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/timetest,v  <--  timetest
new revision: 1.7; previous revision: 1.6
done
Checking in nss/lib/pki1/Makefile;
/cvsroot/mozilla/security/nss/lib/pki1/Makefile,v  <--  Makefile
new revision: 1.8; previous revision: 1.7
done
(Assignee)

Comment 27

10 years ago
Created attachment 264074 [details] [diff] [review]
fixed typo in coreconf/rules.mk

Can't figure out why this happened. But it did bad things. Running nss_build_all caused a failure that did not indicate what make file it was in (probably because the fault was in rules.mk but the command wasn't executed until the rule was applied).
Attachment #263818 - Attachment is obsolete: true
Attachment #264074 - Flags: review?(nelson)
(Assignee)

Updated

10 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 264074 [details] [diff] [review]
fixed typo in coreconf/rules.mk

I just LOVE cryptic languages like Makefiles and shell scripts.  :(
Bring back COBOL!  :)
Attachment #264074 - Flags: review?(nelson) → review+
(Assignee)

Updated

10 years ago
Attachment #264074 - Flags: review?(christophe.ravel.bugs)

Updated

10 years ago
Attachment #264074 - Flags: review?(christophe.ravel.bugs) → review+
(Assignee)

Comment 29

10 years ago
Checking fix in on trunk first.

Checking in mozilla/security/nss/lib/pki1/Makefile;
/cvsroot/mozilla/security/nss/lib/pki1/Makefile,v  <--  Makefile
new revision: 1.10; previous revision: 1.9
done
Checking in mozilla/security/nss/lib/freebl/mpi/timetest;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/timetest,v  <--  timetest
new revision: 1.9; previous revision: 1.8
done
Checking in mozilla/security/nss/lib/freebl/mpi/Makefile.win;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.win,v  <--  Makefile.win
new revision: 1.6; previous revision: 1.5
done
Checking in mozilla/security/nss/lib/freebl/mpi/Makefile.os2;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.os2,v  <--  Makefile.os2
new revision: 1.6; previous revision: 1.5
done
Checking in mozilla/security/nss/lib/freebl/mpi/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile,v  <--  Makefile
new revision: 1.26; previous revision: 1.25
done
Checking in mozilla/security/nss/lib/freebl/ecl/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/ecl/Makefile,v  <--  Makefile
new revision: 1.8; previous revision: 1.7
done
Checking in mozilla/security/nss/lib/ckfw/capi/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/Makefile,v  <--  Makefile
new revision: 1.5; previous revision: 1.4
done
Checking in mozilla/security/nss/lib/ckfw/builtins/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/Makefile,v  <--  Makefile
new revision: 1.19; previous revision: 1.18
done
Checking in mozilla/security/nss/lib/ckfw/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/Makefile,v  <--  Makefile
new revision: 1.13; previous revision: 1.12
done
Checking in mozilla/security/coreconf/rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.75; previous revision: 1.74
done
Checking in mozilla/security/coreconf/command.mk;
/cvsroot/mozilla/security/coreconf/command.mk,v  <--  command.mk
new revision: 1.11; previous revision: 1.10
done
(Assignee)

Comment 30

10 years ago
Checking in 3.11 branch.

Checking in mozilla/security/nss/lib/pki1/Makefile;
/cvsroot/mozilla/security/nss/lib/pki1/Makefile,v  <--  Makefile
new revision: 1.7.28.3; previous revision: 1.7.28.2
done
Checking in mozilla/security/nss/lib/freebl/mpi/timetest;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/timetest,v  <--  timetest
new revision: 1.6.30.3; previous revision: 1.6.30.2
done
Checking in mozilla/security/nss/lib/freebl/mpi/Makefile.win;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.win,v  <--  Makefile.win
new revision: 1.3.30.3; previous revision: 1.3.30.2
done
Checking in mozilla/security/nss/lib/freebl/mpi/Makefile.os2;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile.os2,v  <--  Makefile.os2
new revision: 1.3.30.3; previous revision: 1.3.30.2
done
Checking in mozilla/security/nss/lib/freebl/mpi/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/Makefile,v  <--  Makefile
new revision: 1.22.2.4; previous revision: 1.22.2.3
done
Checking in mozilla/security/nss/lib/freebl/ecl/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/ecl/Makefile,v  <--  Makefile
new revision: 1.2.28.4; previous revision: 1.2.28.3
done
Checking in mozilla/security/nss/lib/ckfw/capi/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/Makefile,v  <--  Makefile
new revision: 1.2.2.3; previous revision: 1.2.2.2
done
Checking in mozilla/security/nss/lib/ckfw/builtins/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/Makefile,v  <--  Makefile
new revision: 1.16.2.3; previous revision: 1.16.2.2
done
Checking in mozilla/security/nss/lib/ckfw/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/Makefile,v  <--  Makefile
new revision: 1.7.28.3; previous revision: 1.7.28.2
done
Checking in mozilla/security/coreconf/rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.66.2.8; previous revision: 1.66.2.7
done
Checking in mozilla/security/coreconf/command.mk;
/cvsroot/mozilla/security/coreconf/command.mk,v  <--  command.mk
new revision: 1.8.2.3; previous revision: 1.8.2.2
done
(Assignee)

Updated

10 years ago
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.