822681 - Robocop: Add test for 'Tabs Drawer Menu' feature

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Cristian Nicolae (:xti)]

This bug tracks the Robocop test the Tabs Drawer Menu button and its options on Firefox for Android.
First, the test opens a new private tab from the Tabs Drawer Menu,then it opens a new general tab from the Tabs Drawer Menu and finally it closes all tabs through the Close All Tabs option in the Tabs Drawer Menu.

Comment 1

[Cristian Nicolae (:xti)]

Attachment: Tabs Drawer Menu patch V1.0

Comment 2

[Cristian Nicolae (:xti)]

Attachment: Tabs Drawer Menu patch V1.1

Cleared some spaces

Comment 3

[Joel Maher ( :jmaher ) (PTO: back Nov 2nd) (UTC -0700)]

this patch doesn't apply, can you fix it up and upload the working one?

Comment 4

[Cristian Nicolae (:xti)]

Attachment: Tabs Drawer Menu patch V2.0

I updated and extended the previous patch

Comment 5

[Joel Maher ( :jmaher ) (PTO: back Nov 2nd) (UTC -0700)]

Comment on attachment 694367 [details] [diff] [review]
Tabs Drawer Menu patch V2.0

Review of attachment 694367 [details] [diff] [review]:
-----------------------------------------------------------------

pretty good patch.  I am going to r- due to it failing locally.  If you have suggestions for debugging, I would appreciate it.

::: mobile/android/base/tests/testTabsTrayMenu.java.in
@@ +60,5 @@
> +
> +        // Verifying if the private data is not listed in Awesomescreen
> +        clickOnAwesomeBar();
> +        mSolo.clickOnText("History");
> +        mAsserter.ok(mSolo.waitForText("Browser Blank Page 01"), "Looking in History for the page loaded in the normal tab", "Fount it");

s/Fount/Found/

For some reason this fails for me all the time at this spot.  I am testing on the tegras we use for automation.

@@ +73,5 @@
> +        mAsserter.is(tabCountInt, expectedTabCount, "Number of tabs is 1");
> +    }
> +
> +    private void addNewTab(String url) {
> +        

nit: extra whitespace/tab here.

@@ +83,5 @@
> +        mSolo.clickOnText("New Tab");
> +
> +        /* Must pause before sending keys, until awesome bar is displayed; waiting for
> +        known text is simple
> +        */

no need to add 'waiting for known text is simple'

@@ +89,5 @@
> +
> +        // Cannot use loadUrl(): getText fails because we are using a different urlbar
> +        mActions.sendKeys(url);
> +        hitEnterAndWait();
> +    }

this method would make a good general method for other tests.  We could file a followup bug to do that.

@@ +103,5 @@
> +
> +        // Waiting for about:home opened in Private Mode
> +        mSolo.waitForText("Enter Search or Address");
> +
> +        loadUrl(url);

for a regular tab above, we need sendKeys() and hitEnterAndWait().  I would like to know more about the urlbar differences between regular and private browsing.

Comment 6

[Joel Maher ( :jmaher ) (PTO: back Nov 2nd) (UTC -0700)]

Comment on attachment 694367 [details] [diff] [review]
Tabs Drawer Menu patch V2.0

Review of attachment 694367 [details] [diff] [review]:
-----------------------------------------------------------------

I had an issue in my local environment, I have tested this locally and on try server with success!

Comment 7

[Joel Maher ( :jmaher ) (PTO: back Nov 2nd) (UTC -0700)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47edb66a0137

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/47a1fba72004