Closed
Bug 822681
Opened 12 years ago
Closed 12 years ago
Robocop: Add test for 'Tabs Drawer Menu' feature
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: xti, Assigned: xti)
References
Details
Attachments
(1 file, 2 obsolete files)
5.59 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
This bug tracks the Robocop test the Tabs Drawer Menu button and its options on Firefox for Android.
First, the test opens a new private tab from the Tabs Drawer Menu,then it opens a new general tab from the Tabs Drawer Menu and finally it closes all tabs through the Close All Tabs option in the Tabs Drawer Menu.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Cleared some spaces
Attachment #693424 -
Attachment is obsolete: true
Attachment #693427 -
Flags: review?(jmaher)
Comment 3•12 years ago
|
||
this patch doesn't apply, can you fix it up and upload the working one?
Assignee | ||
Comment 4•12 years ago
|
||
I updated and extended the previous patch
Attachment #693427 -
Attachment is obsolete: true
Attachment #693427 -
Flags: review?(jmaher)
Attachment #694367 -
Flags: review?(jmaher)
Comment 5•12 years ago
|
||
Comment on attachment 694367 [details] [diff] [review]
Tabs Drawer Menu patch V2.0
Review of attachment 694367 [details] [diff] [review]:
-----------------------------------------------------------------
pretty good patch. I am going to r- due to it failing locally. If you have suggestions for debugging, I would appreciate it.
::: mobile/android/base/tests/testTabsTrayMenu.java.in
@@ +60,5 @@
> +
> + // Verifying if the private data is not listed in Awesomescreen
> + clickOnAwesomeBar();
> + mSolo.clickOnText("History");
> + mAsserter.ok(mSolo.waitForText("Browser Blank Page 01"), "Looking in History for the page loaded in the normal tab", "Fount it");
s/Fount/Found/
For some reason this fails for me all the time at this spot. I am testing on the tegras we use for automation.
@@ +73,5 @@
> + mAsserter.is(tabCountInt, expectedTabCount, "Number of tabs is 1");
> + }
> +
> + private void addNewTab(String url) {
> +
nit: extra whitespace/tab here.
@@ +83,5 @@
> + mSolo.clickOnText("New Tab");
> +
> + /* Must pause before sending keys, until awesome bar is displayed; waiting for
> + known text is simple
> + */
no need to add 'waiting for known text is simple'
@@ +89,5 @@
> +
> + // Cannot use loadUrl(): getText fails because we are using a different urlbar
> + mActions.sendKeys(url);
> + hitEnterAndWait();
> + }
this method would make a good general method for other tests. We could file a followup bug to do that.
@@ +103,5 @@
> +
> + // Waiting for about:home opened in Private Mode
> + mSolo.waitForText("Enter Search or Address");
> +
> + loadUrl(url);
for a regular tab above, we need sendKeys() and hitEnterAndWait(). I would like to know more about the urlbar differences between regular and private browsing.
Attachment #694367 -
Flags: review?(jmaher) → review-
Comment 6•12 years ago
|
||
Comment on attachment 694367 [details] [diff] [review]
Tabs Drawer Menu patch V2.0
Review of attachment 694367 [details] [diff] [review]:
-----------------------------------------------------------------
I had an issue in my local environment, I have tested this locally and on try server with success!
Attachment #694367 -
Flags: review- → review+
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
Assignee: nobody → nicolae.cristian
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•