I can't seem to get to the ``Text Color'' dialog by choosing ``Format -> Text Color'' in composer. To reproduce: 1. Type some text. 2. Select some of it. 3. Choose ``Text Color'' from the ``Format'' menu Expected: dialog appears Actual: nothing happens.
I see this also...
9.1 -- cmanske
Assignee: beppe → cmanske
Severity: major → critical
Priority: -- → P1
Target Milestone: --- → mozilla0.9.1
Simon broke it with recent plaintext editor commands checkin. Fix comming.
Status: NEW → ASSIGNED
Whiteboard: [dialog] → [dialog] FIX IN HAND need r=, sr=
Simon: I tested openning a text file, and the Format | Text Color command is disabled correctly with this fix.
this works from the tool bar on 2001 05 22 04 build... is that good enough for 0.9.1/beta?
Nominating brade for the r= and sfraser for sr= (unless waterson wants to assist)
Given how trivial the fix is, let's get in in now!
The fix isn't "new", btw, it restores previous code.
Why doesn't the goDoCommand work?
It only gets/sets the "state", doesn't actually change the color! As the comment in the patch says, it should be "cmd_fontColorState". I suppose we should add a new "cmd_FontColor" command to avoid the direct editor call, but that should wait for 0.9.2?
Well, that seems pretty weird. sr=sfraser on the change
This was just broken this past week; we should fix it. r=brade
a=blizzard for 0.9.1
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Whiteboard: [dialog] FIX IN HAND → [dialog]
verified in 5/30 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.