82276 - Import eudora address book fails to include address cards if email address is missing

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P1)

Description

[fenella]

Win32 (2001-05-22-06 trunk)
Mac (2001-05-21-15 trunk)
1. Create an address book and address cards in the Eudora mail
2. From Seamonkey's Address Book, select File->Import
3. Select Address Book and select Eudora
4. Click Next
5. Click Finish
6. From Seamonkey Address Book, Click on the Eudora Address Book that was just
imported

Actual result:  No address card is listed in the Result pane

Expect result: Address card should be imported along with the Address Book.

Comment 1

[Ninoschka Baca]

Branch build 2001-09-14: WinMe
This is still true. Marking nsbranch so this issue is brought to someone's
attention. I'm not sure if this is important to enterprise. I think most
enterprises use Outlook?

Comment 2

[Cindy Roberts]

There aren't any comments on this bug since the 16th of
Sept.  Can QA regess against the Netscape commercial builds and determine if
this is still a valid bug?  If so, and we can get fixes/reviews in the next day
or two, please mark as nsbranch+ which will get this on the PDT radar. Else,
mark is as nsbranch-. Also, can someone comment in the bug how serious you think
this is?  PDT is only accepting "stop ship" bugs such as data loss and loss of
major functionality.

Comment 3

[lchiang]

Does this mean that Eudora import is not working if address book cards / entries
do not show up?

cc: mscott.

Comment 4

[Ninoschka Baca]

Lisa, I'm not sure what you are asking. 

There are 3 different processes when importing from Eudora:

1. Import Mail: Just imports local mail which is working.
2. Import Settings: This imports the Eudora settings so that you can
send/receive messages.
3. Import Address Book: The name of the address books appear in the left pane.
Select one of the Eudora address books and No address cards appear in the right.
This is the problem described in this bug.

Comment 5

[lchiang]

I got the answer --> Eudora import of address book entries is not working.  Is
there a workaround we can give the user?

Comment 6

[Jaime Rodriguez, Jr.]

ETa pls ...

Comment 7

[Scott MacGregor]

We've lost our address book expert and I don't have anyone that's familiar with
this code so the ramp up could be a couple days. I would like to minus this bug
for the branch unless eclient believes this is a stopper.

Comment 8

[Jeff Hooker]

not a stopper at this time for enterprise deployment of emojo

Comment 9

[Ninoschka Baca]

I don't know of a workaround:
- I don't see an option in Eudora to export a file. 
- After importing I looked at the impab.mab file and it basically has no data
from the Eudora Address Book.

Comment 10

[Hong Kwon]

Is this a regression?  Eudora doesn't have significant penetration among our
enterprise customers so it isn't a stopship priority for our release.  If it is
a regression it should be fixed.

Comment 11

[Jaime Rodriguez, Jr.]

if this is not a regression, i suggest we minus this one.

Comment 12

[Scott MacGregor]

minusing for the branch. I don't believe this is a pull it off the wire kind of bug.

Comment 13

[scottputterman]

reassigning to cavin

Comment 14

[Ninoschka Baca]

Marking nsbeta1.

Trunk build 2002-01-07-03: WinMe
Eudora's AB has cards and two groups (aka mail lists). After importing into 
today's trunk build it displays the name of the address books in the left pane  
but no cards/groups.

Comment 15

[Cavin Song]

If you don't enter any email address (ie, in the space where it says "This
nickname will expand to the following addresses:") for an Eudora addrbook
entry/card then the card won't be imported.

In addition, some of the Eudora addrbook fields are not mapped. For example,
both home and work address and web links are dropped.

Comment 16

[Cavin Song]

Attachment: Proposed fix, v1

The patch fixes the following:
1. Allows Eudora addrbook cards without email addresses to be imported.
2. Additional Eudora addrbook card fields (such as street address, city, web
links, etc) are now mappped correctly to our own address fields.  The mapping
also includes the 2nd Eudora email address if specified (mapped to dditional
Email:" field). These fields were ignored before.

Comment 17

[Scott MacGregor]

Comment on attachment 67755 [details] [diff] [review]
Proposed fix, v1

sr=mscott

Just for kicks, could we pass in a nsAutoString as an argument to your macro:
ADD_FIELD_TO_DB_ROW to be used as uniStr? That way when the macro expands we
won't be creating so many temporary string objects, we can just re-use one.

Comment 18

[Cavin Song]

Good idea, Scott. I'll do that when I check in the patch.

Comment 19

[Jean-Francois Ducarroz]

Comment on attachment 67755 [details] [diff] [review]
Proposed fix, v1

r=ducarroz

Comment 20

[Cavin Song]

Fix checked in.

Comment 21

[Ninoschka Baca]

Trunk build 2002-03-01: WinMe, Fixed.
Trunk build 2002-03-01: Mac 9.1, does not import cards with no email address.

Reopening due to problem on the Mac.

Comment 22

[saari (gone)]

nsbeta1- as per ADT

Comment 23

[Cavin Song]

> Trunk build 2002-03-01: Mac 9.1, does not import cards with no email address.
>
I'm looking into the Mac problem.

Comment 24

[Cavin Song]

The problem is that on Mac the string for a Eudora contact without email address 
is returned as:

 "alias Cavin ,"

whereas on windows the string is:

 "alias Cavin "

I don't know why there's such a difference but the extra comma causes one of the 
function to fail because there's no other attributes after the comma. The fix is 
to always return the allocated entry in that function even if there is no 
attribute associated with a contact. A patch is coming.

Comment 25

[Cavin Song]

Attachment: Proposed patch for Mac problem, v1

Always return the entry even if there's no other attribute associated with the
contact.

Comment 26

[Cavin Song]

This patch works fine on both windows and Mac.

Comment 27

[Jean-Francois Ducarroz]

Comment on attachment 83137 [details] [diff] [review]
Proposed patch for Mac problem, v1

R=ducarroz

Comment 28

[Scott MacGregor]

Comment on attachment 83137 [details] [diff] [review]
Proposed patch for Mac problem, v1

sr=mscott

Comment 29

[Cavin Song]

Fix landed on the trunk.

Comment 30

[Cavin Song]

Nominating for RTM.

Comment 31

[Ninoschka Baca]

Trunk build 2002-05-28: WinMe, Mac 9.1
Verified Fixed. Now cards without an email address also import from Eudora.

Comment 32

[Judson Valeski]

please checkin to the 1.0.1 branch ASAP, and replace the mozilla1.0.1+ keyword
with fixed1.0.1 once it's landed there.

Comment 33

[Cavin Song]

Fix checked in to branch.

Comment 34

[Jaime Rodriguez, Jr.]

posthumus + for checkin to 1.0.

Comment 35

[Ninoschka Baca]

Branch build 2002-06-11: WinMe
verified1.0.1

Comment 36

[Wayne Mery (:wsmwk)]

*** Bug 58929 has been marked as a duplicate of this bug. ***