822807 - Add question->products and question->topics to search index.

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P2)

Description

[Ricky Rosario [:rrosario, :r1cky]]

We need to do the two step mapping change for this.

Step 1:
* Add question_products and question_topics to the mapping
* Fill in those values in the extract_document() method
* Create a new ES_WRITE_INDEX in settings.py
* Land and deploy
* Reindex everything

Step 2:
* Add code to the search view to filter questions by product and topic
* Add UI to the Advanced Search form
* Set ES_READ_INDEX to the new ES_WRITE_INDEX so they are the same again.
* Land and deploy
* DONE!

Given all this => 3pt

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

This isn't really user facing at this point.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Also... If we want to use ES to facet results by product and topic (across documents and questions), we need to use the same field name for both mappings. In other words, we should rename 'document_product' to 'product' and 'document_topic' to 'topic'. And the new fields for the question mapping will also be 'product' and 'topic'.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

That might get messy. We'd need to make sure that contributor forum results don't get nixed from advanced search because they won't have products or topics.

And we might need to double-check the support forum questions to make sure they do have products and topics.

Also, product and topic should be arrays of strings and not analyzed (or use the keyword analyzer). Figured I'd mention it.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Will Kahn-Greene [:willkg] from comment #3)
> That might get messy. We'd need to make sure that contributor forum results
> don't get nixed from advanced search because they won't have products or
> topics.

I'm don't think I see how this can happen, but I'll find out. When I get into it.

 
> And we might need to double-check the support forum questions to make sure
> they do have products and topics.

Newer ones do now (since a few weeks back). Of course, older ones won't show up when filtering by product or topic. That's fine.

> Also, product and topic should be arrays of strings and not analyzed (or use
> the keyword analyzer). Figured I'd mention it.

Yep, that's how we are doing it for documents so I'll just copy that.
    'document_product': {'type': 'string', 'index': 'not_analyzed'},
    'document_topic': {'type': 'string', 'index': 'not_analyzed'},

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

This may have been really a 2pter. Although I haven't gotten to the fun deployment part.

Pull request:
https://github.com/mozilla/kitsune/pull/1016

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master....

Step 1: https://github.com/mozilla/kitsune/commit/18eaed85d86350acaa44bbe76850650b03640a06

Step 2: https://github.com/mozilla/kitsune/commit/7ff9dfe95720478a00a67d56efe338d5f3f84e56

Now I'll start the deployment dance on -stage and then -prod later today.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Deployed it all!