822820 - Update SUMO URL in default bookmarks

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

In bug 822462 the SUMO devs were expecting that Firefox for Android would just point to https://support.mozilla.org it would be good to update the in product bookmark to SUMO and at the same time update the SUMO helping hand favicon to the Firefox favicon.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

SUMO just uses the Firefox icon now. Rather than shipping it, I think maybe its easiest to just use our branding... that could eventually be wrong (but so would the Firefox icon if we shipped it?)

Comment 2

[:Margaret Leibovic]

Comment on attachment 742103 [details] [diff] [review]
Patch

Empty patch...

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Doh!

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

Trying to clean up some backlog.

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/74a99b693466

Comment 6

[Wesley Johnston (:wesj)]

Whoops. Remembered that we have tests for this. Pushed a fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4f1cec360dd

Comment 7

[Peter Retzer (:pretzer)]

These patches landed on inbound 3 month ago... what happen then? It doesn't seem they sticked as the bookmark still uses the old favicon and URL in the latest nightly build.

Comment 8

[Aaron Train [:aaronmt]]

In this bug, the only thing that landed is a URL update.

Comment 9

[Wesley Johnston (:wesj)]

This was backed out, but didn't make it here somehow :)

http://hg.mozilla.org/mozilla-central/rev/4ed5d59526cb

Comment 10

[Aaron Train [:aaronmt]]

Favicon -> mentor patch?

Comment 11

[Richard Newman [:rnewman]]

Morphing description in light of Bug 921433.

Comment 12

[Richard Newman [:rnewman]]

Yoink!

Comment 13

[Lucas Rocha (:lucasr)]

The default SUMO suggested site (in region.properties) has to be update too btw. Keep the locale specific URL though: https://support.mozilla.org/en-US/

Comment 14

[Richard Newman [:rnewman]]

(In reply to Lucas Rocha (:lucasr) from comment #13)
> The default SUMO suggested site (in region.properties) has to be update too
> btw. Keep the locale specific URL though: https://support.mozilla.org/en-US/

I tested, and SUMO correctly redirects based on request headers. (As do all of our web properties.)

For bookmarks in particular, given that they're created before the user has picked a locale, I think hard-coding a locale code is a really bad idea.

Suggested sites switch based on locale, so less of a concern there.

Comment 15

[Richard Newman [:rnewman]]

Attachment: Update SUMO and AMO URLs in default bookmarks

Comment 16

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8457610 [details] [diff] [review]
Update SUMO and AMO URLs in default bookmarks

Review of attachment 8457610 [details] [diff] [review]:
-----------------------------------------------------------------

wfm.  You've tested the redirect after switching locale, correct?

Comment 17

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #16)

> wfm.  You've tested the redirect after switching locale, correct?

Yes. It seems to now require a Gecko relaunch -- Accept-Language doesn't change after a locale switch, so there's something stale hiding in Gecko. But this is strictly better than we have now: your future visits to AMO and SUMO will reflect your selected locale, not the system locale at the instant you installed Firefox.

Also, it's a good job I'm hacking on this: our current SUMO URL doesn't load the mobile site by default, which seems like a serious omission!

Comment 18

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/70c675963e76

Comment 19

[Richard Newman [:rnewman]]

Comment on attachment 8457610 [details] [diff] [review]
Update SUMO and AMO URLs in default bookmarks

Approval Request Comment
[Feature/regressing bug #]:
  None in particular.

[User impact if declined]:
  SUMO and AMO URLs will hard-code locales, defeating locale switching.
  Note that I did not point directly to support.mozilla.org in this patch.

[Describe test coverage new/current, TBPL]:
  Simple URL change.

[Risks and why]: 
  Improved experience during locale switching.

[String/UUID change made/needed]:
  None.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70c675963e76

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3d6875a84472

Comment 22

[Richard Newman [:rnewman]]

This needed Bug 1039925 to be uplifted to avoid test failures.

https://hg.mozilla.org/releases/mozilla-aurora/rev/bd29d7d1239b

Comment 23

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Samsung Galaxy Nexus
OS: Android 4.2.1
SUMO url is: https://support.mozilla.org/products/mobile 
AMO URL is: https://addons.mozilla.org/android/ 
Verified fixed on:
Build: Firefox for Android 32 Beta 1