Closed Bug 822820 Opened 7 years ago Closed 5 years ago

Update SUMO URL in default bookmarks

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 33
Tracking Status
firefox32 --- verified
firefox33 --- verified

People

(Reporter: kbrosnan, Assigned: rnewman, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=java][good first bug] ui-hackathon [exterminationweek])

Attachments

(1 file, 3 obsolete files)

In bug 822462 the SUMO devs were expecting that Firefox for Android would just point to https://support.mozilla.org it would be good to update the in product bookmark to SUMO and at the same time update the SUMO helping hand favicon to the Firefox favicon.
Whiteboard: ui-hackathon
Attached patch Patch (obsolete) — Splinter Review
SUMO just uses the Firefox icon now. Rather than shipping it, I think maybe its easiest to just use our branding... that could eventually be wrong (but so would the Firefox icon if we shipped it?)
Attachment #742103 - Flags: review?(margaret.leibovic)
Comment on attachment 742103 [details] [diff] [review]
Patch

Empty patch...
Attachment #742103 - Flags: review?(margaret.leibovic) → review-
Assignee: nobody → wjohnston
Attached patch Patch v1 (obsolete) — Splinter Review
Doh!
Attachment #742103 - Attachment is obsolete: true
Attachment #748268 - Flags: review?(margaret.leibovic)
Attachment #748268 - Flags: review?(margaret.leibovic) → review+
Attached patch Patch (obsolete) — Splinter Review
Trying to clean up some backlog.
Attachment #748268 - Attachment is obsolete: true
Attachment #770282 - Flags: review?(margaret.leibovic)
Attachment #770282 - Flags: review?(margaret.leibovic) → review+
Whoops. Remembered that we have tests for this. Pushed a fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4f1cec360dd
These patches landed on inbound 3 month ago... what happen then? It doesn't seem they sticked as the bookmark still uses the old favicon and URL in the latest nightly build.
Flags: needinfo?(wjohnston)
In this bug, the only thing that landed is a URL update.
This was backed out, but didn't make it here somehow :)

http://hg.mozilla.org/mozilla-central/rev/4ed5d59526cb
Flags: needinfo?(wjohnston)
Favicon -> mentor patch?
Hardware: ARM → All
Whiteboard: ui-hackathon → [mentor=rnewman][lang=java][good first bug] ui-hackathon
Depends on: 921433
Whiteboard: [mentor=rnewman][lang=java][good first bug] ui-hackathon → [mentor=rnewman][lang=java][good first bug] ui-hackathon [exterminationweek]
Component: General → Favicon Handling
Blocks: 999920
Mentor: rnewman
Whiteboard: [mentor=rnewman][lang=java][good first bug] ui-hackathon [exterminationweek] → [lang=java][good first bug] ui-hackathon [exterminationweek]
Morphing description in light of Bug 921433.
Component: Favicon Handling → General
Summary: Update SUMO favicon and URL → Update SUMO URL in default bookmarks
Yoink!
Assignee: wjohnston → rnewman
Status: NEW → ASSIGNED
The default SUMO suggested site (in region.properties) has to be update too btw. Keep the locale specific URL though: https://support.mozilla.org/en-US/
(In reply to Lucas Rocha (:lucasr) from comment #13)
> The default SUMO suggested site (in region.properties) has to be update too
> btw. Keep the locale specific URL though: https://support.mozilla.org/en-US/

I tested, and SUMO correctly redirects based on request headers. (As do all of our web properties.)

For bookmarks in particular, given that they're created before the user has picked a locale, I think hard-coding a locale code is a really bad idea.

Suggested sites switch based on locale, so less of a concern there.
Comment on attachment 8457610 [details] [diff] [review]
Update SUMO and AMO URLs in default bookmarks

Review of attachment 8457610 [details] [diff] [review]:
-----------------------------------------------------------------

wfm.  You've tested the redirect after switching locale, correct?
Attachment #8457610 - Flags: review?(nalexander) → review+
(In reply to Nick Alexander :nalexander from comment #16)

> wfm.  You've tested the redirect after switching locale, correct?

Yes. It seems to now require a Gecko relaunch -- Accept-Language doesn't change after a locale switch, so there's something stale hiding in Gecko. But this is strictly better than we have now: your future visits to AMO and SUMO will reflect your selected locale, not the system locale at the instant you installed Firefox.

Also, it's a good job I'm hacking on this: our current SUMO URL doesn't load the mobile site by default, which seems like a serious omission!
Attachment #770282 - Attachment is obsolete: true
Comment on attachment 8457610 [details] [diff] [review]
Update SUMO and AMO URLs in default bookmarks

Approval Request Comment
[Feature/regressing bug #]:
  None in particular.

[User impact if declined]:
  SUMO and AMO URLs will hard-code locales, defeating locale switching.
  Note that I did not point directly to support.mozilla.org in this patch.

[Describe test coverage new/current, TBPL]:
  Simple URL change.

[Risks and why]: 
  Improved experience during locale switching.

[String/UUID change made/needed]:
  None.
Attachment #8457610 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/70c675963e76
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Attachment #8457610 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
This needed Bug 1039925 to be uplifted to avoid test failures.

https://hg.mozilla.org/releases/mozilla-aurora/rev/bd29d7d1239b
Tested with:
Device: Samsung Galaxy Nexus
OS: Android 4.2.1
SUMO url is: https://support.mozilla.org/products/mobile 
AMO URL is: https://addons.mozilla.org/android/ 
Verified fixed on:
Build: Firefox for Android 32 Beta 1
You need to log in before you can comment on or make changes to this bug.