822859 - ForwardButton on tablets doesn't have a border

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

The Forward button on tablets doesn't show an outline. Earlier the size of forward button was 42dp fitting inside the URL bar. Now the size of the url bar is shrunk to 40dp, but the forward button is still at 42dp and hence feels like the outline is lost.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Screenshots

With some experiments, I need UX input on a call to make here.
If the height of the forward button is 40dp, the highlight around the url-bar lacks 1px and looks very odd. But this was a change (increasing forward button height) made recently to make it touch the url-bar.
If the height of the forward button is 38dp, the highlight is perfect without the 1px problem. I am not sure if that looks good on default state.

Comment 2

[Ian Barlow (:ibarlow)]

The background looks good at 38dp. I do think that button needs to be 2dp wider or so, the forward button looks pretty tight in there right now.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Replaced the images and shrunk the height.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90d5da5a2241

Comment 5

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/90d5da5a2241

Comment 6

[Adrian Tamas (:AdrianT)]

Issue is no longer reproducible on Aurora 20.0a2 2013-01-10 or Nightly 21.0a1 2013-01-10 on the Asus EEE Transformers TF101 (Android 4.0.3). Marking the issue as verified