Closed Bug 822877 Opened 12 years ago Closed 6 years ago

Animating a huge (infinite) value produces NaN, which asserts

Categories

(Core :: CSS Parsing and Computation, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jruderman, Unassigned)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files, 1 obsolete file)

Assertion failure: !MOZ_DOUBLE_IS_NaN(mValue.mFloat), at layout/style/nsCSSValue.cpp:325
Attached file stack
The assertion was added in bug 798853, not too long ago -- tentatively assuming this has been an issue since then, & marking as blocking that bug.
Attached patch fix+test (obsolete) — Splinter Review
Assignee: nobody → matspal
Attachment #695370 - Flags: review?(dbaron)
Comment on attachment 695370 [details] [diff] [review]
fix+test

Fixing just this one caller doesn't feel right when there are probably others.  Furthermore, I think in cases where we're unable to animate, we should fail rather than use a dummy (0) value.
Attachment #695370 - Attachment is obsolete: true
Attachment #695370 - Flags: review?(dbaron)
Assignee: matspal → nobody
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: