Closed
Bug 822980
Opened 12 years ago
Closed 11 years ago
backport bug 815532 to bmo (Bugzilla::User objects should be cached where appropriate)
Categories
(bugzilla.mozilla.org :: General, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: dkl)
Details
Attachments
(1 file, 2 obsolete files)
6.86 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Updated patch for bmo/4.2
Attachment #694575 -
Attachment is obsolete: true
Attachment #694575 -
Flags: review?(glob)
Attachment #764848 -
Flags: review?(glob)
Comment on attachment 764848 [details] [diff] [review] Patch to cache user objects where appropriate (4.2) (v1) Review of attachment 764848 [details] [diff] [review]: ----------------------------------------------------------------- this patch adds trailing whitespace ::: Bugzilla/Object.pm @@ +173,4 @@ > my $class = ref($invocant) || $invocant; > # If we were just passed a name, then just use the name. > if (!ref $param) { > + $param = { name => $param, cache => 1 }; this isn't in the upstream patch, and changes caching to be used by default for all check() calls. while i'd love to use caching by default, this isn't the bug to flip that switch.
Attachment #764848 -
Flags: review?(glob) → review-
Assignee | ||
Comment 4•11 years ago
|
||
Thanks for the review. New patch. dkl
Attachment #764848 -
Attachment is obsolete: true
Attachment #769825 -
Flags: review?(glob)
Comment on attachment 769825 [details] [diff] [review] Patch to cache user objects where appropriate (4.2) (v2) r=glob
Attachment #769825 -
Flags: review?(glob) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2 modified Bugzilla/Attachment.pm modified Bugzilla/Bug.pm modified Bugzilla/BugMail.pm modified Bugzilla/Comment.pm modified Bugzilla/Component.pm modified Bugzilla/Flag.pm modified Bugzilla/FlagType.pm Committed revision 8871.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•