822980 - backport bug 815532 to bmo (Bugzilla::User objects should be cached where appropriate)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to cache user objects where appropriate (4.0) (v1)

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to cache user objects where appropriate (4.2) (v1)

Updated patch for bmo/4.2

Comment 3

[:glob ✱]

Comment on attachment 764848 [details] [diff] [review]
Patch to cache user objects where appropriate (4.2) (v1)

Review of attachment 764848 [details] [diff] [review]:
-----------------------------------------------------------------

this patch adds trailing whitespace

::: Bugzilla/Object.pm
@@ +173,4 @@
>      my $class = ref($invocant) || $invocant;
>      # If we were just passed a name, then just use the name.
>      if (!ref $param) {
> +        $param = { name => $param, cache => 1 };

this isn't in the upstream patch, and changes caching to be used by default for all check() calls.  while i'd love to use caching by default, this isn't the bug to flip that switch.

Comment 4

[David Lawrence [:dkl]]

Attachment: Patch to cache user objects where appropriate (4.2) (v2)

Thanks for the review. New patch.

dkl

Comment 5

[:glob ✱]

Comment on attachment 769825 [details] [diff] [review]
Patch to cache user objects where appropriate (4.2) (v2)

r=glob

Comment 6

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified Bugzilla/Attachment.pm
modified Bugzilla/Bug.pm
modified Bugzilla/BugMail.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Component.pm
modified Bugzilla/Flag.pm
modified Bugzilla/FlagType.pm
Committed revision 8871.