823017 - validator is complaining about orientation values

Status: RESOLVED INVALID

(Marketplace Graveyard :: Validation, defect)

Description

[Andrew Williamson [:eviljeff]]

The brandUn DeShay app manifest is reporting the orientation is invalid in the manifest but I thought I fixed that with https://github.com/mozilla/app-validator/pull/3

https://marketplace.firefox.com/developers/upload/6cd8c455f4a4431cb40364cc09c3f80f

Comment 1

[Matt Basta [:basta]]

It's invalid because the validator expects an array and the manifest provides a comma-delimited string.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

It used to be a comma-delimited string. Has the spec changed to be correct?

Comment 3

[Matt Basta [:basta]]

Yes

Comment 4

[Andrew Williamson [:eviljeff]]

Do you know when the spec changed to only allow array style and if the old style still works in the runtime?  We might need to run a clean up of existing apps.

Comment 5

[Matt Basta [:basta]]

This change was made three months ago. Any apps that used the old style would have been been revalidated via the cron and marked as invalid (with an error). From there, they would have presumably been notified and the app removed from the marketplace.