Last Comment Bug 823042 - "variable status redeclares argument" from update.js in error console
: "variable status redeclares argument" from update.js in error console
Status: RESOLVED FIXED
:
Product: Toolkit
Classification: Components
Component: Add-ons Manager (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla20
Assigned To: Jonathan Kamens
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-19 06:07 PST by Jonathan Kamens
Modified: 2012-12-23 13:04 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
rename function-local status variable (1.61 KB, patch)
2012-12-19 06:23 PST, Jonathan Kamens
dtownsend: review+
Details | Diff | Splinter Review

Description Jonathan Kamens 2012-12-19 06:07:12 PST
Timestamp: 12/19/2012 09:00:12 AM
Warning: TypeError: variable status redeclares argument
Source File: chrome://mozapps/content/extensions/update.js
Line: 216, Column: 8
Source Code:
    var status = document.getElementById("versioninfo.status"); 

Timestamp: 12/19/2012 09:00:12 AM
Warning: TypeError: variable status redeclares argument
Source File: chrome://mozapps/content/extensions/update.js
Line: 290, Column: 8
Source Code:
    var status = document.getElementById("checking.status"); 

I will attach a proposed (trivial) patch.
Comment 1 Jonathan Kamens 2012-12-19 06:23:35 PST
Created attachment 693853 [details] [diff] [review]
rename function-local status variable
Comment 2 Georg Fritzsche [:gfritzsche] 2012-12-19 06:35:50 PST
This is in the browser module, although i'm not entirely sure which specific component in the Firefox product this should be in.
Comment 3 Jonathan Kamens 2012-12-19 06:36:47 PST
(In reply to Georg Fritzsche [:gfritzsche] from comment #2)
> This is in the browser module, although i'm not entirely sure which specific
> component in the Firefox product this should be in.

It's used by Thunderbird (I saw the error in the error console in TB, not Firefox), so I don't think the bug belongs in the browser module.
Comment 4 Georg Fritzsche [:gfritzsche] 2012-12-19 06:45:00 PST
Sorry, took a second look - the affected part is in toolkit, so moving it there.
Comment 5 Georg Fritzsche [:gfritzsche] 2012-12-19 06:46:22 PST
Comment on attachment 693853 [details] [diff] [review]
rename function-local status variable

Clearing out the review request for Josh as he's not a peer there.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-12-23 08:50:27 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f74d77d6d8b
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-12-23 13:04:11 PST
https://hg.mozilla.org/mozilla-central/rev/4f74d77d6d8b

Note You need to log in before you can comment on or make changes to this bug.