"variable status redeclares argument" from update.js in error console

RESOLVED FIXED in mozilla20

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Jonathan Kamens, Assigned: Jonathan Kamens)

Tracking

Trunk
mozilla20
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Timestamp: 12/19/2012 09:00:12 AM
Warning: TypeError: variable status redeclares argument
Source File: chrome://mozapps/content/extensions/update.js
Line: 216, Column: 8
Source Code:
    var status = document.getElementById("versioninfo.status"); 

Timestamp: 12/19/2012 09:00:12 AM
Warning: TypeError: variable status redeclares argument
Source File: chrome://mozapps/content/extensions/update.js
Line: 290, Column: 8
Source Code:
    var status = document.getElementById("checking.status"); 

I will attach a proposed (trivial) patch.
(Assignee)

Comment 1

4 years ago
Created attachment 693853 [details] [diff] [review]
rename function-local status variable
Attachment #693853 - Flags: review?(joshmoz)
(Assignee)

Updated

4 years ago
Assignee: nobody → jik
Status: NEW → ASSIGNED
This is in the browser module, although i'm not entirely sure which specific component in the Firefox product this should be in.
Component: Plug-ins → General
Product: Core → Firefox
(Assignee)

Comment 3

4 years ago
(In reply to Georg Fritzsche [:gfritzsche] from comment #2)
> This is in the browser module, although i'm not entirely sure which specific
> component in the Firefox product this should be in.

It's used by Thunderbird (I saw the error in the error console in TB, not Firefox), so I don't think the bug belongs in the browser module.
Sorry, took a second look - the affected part is in toolkit, so moving it there.
Component: General → Add-ons Manager
Product: Firefox → Toolkit
Comment on attachment 693853 [details] [diff] [review]
rename function-local status variable

Clearing out the review request for Josh as he's not a peer there.
Attachment #693853 - Flags: review?(joshmoz)
(Assignee)

Updated

4 years ago
Attachment #693853 - Flags: review?(dtownsend+bugmail)
Attachment #693853 - Flags: review?(dtownsend+bugmail) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f74d77d6d8b
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4f74d77d6d8b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.