823057 - Links point to en-US URLs

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[Guillermo López :willyaranda (probably SLOW response)]

https://github.com/mozilla-b2g/gaia/blob/master/apps/browser/locales/browser.en-US.properties#L53

support-about.href=http://support.mozilla.org/1/firefox-os/1.0/firefox-os/en-US

faq-about.href=https://www.mozilla.org/en-US/firefox/mobile/faq/?os=firefox-os

They should not have any 'en-US' inside. Maybe the localeCode of the Gaia in that moment, or directly no language code, and then SUMO and Mozilla.org backends should redirect users, like it's done actually with other products.

Comment 1

[Axel Hecht [:Pike]]

The got introduced in bug 802545, and it seems they didn't get proper l10n review at the time.

I request this to block basecamp. The FAQ link is just wrong, AFAICT.

Please change the urls to be locale agnostic, and remove them from the .properties files and move them to code. That's taking the most advantage out of the infrastructure we have server side, and allows us to adjust the URLs for the FAQ for example to something more focused once we have that.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, C3, P1 - for l10n impact and regression

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I can take it, but I need to know where should the strings be put? Vivien?

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I would also need to know whether or not there should be two versions of URLs for official and unofficial build.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Pike, given the fact that Vivien has been unresponsive for 3 days, could you answer my questions above? Thanks.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Like, what does Firefox do, as a prior-art?

Comment 7

[Axel Hecht [:Pike]]

Grace, is Firefox OS FAQ you?

The support ref should just pick the locale code from the runtime, and pass that along.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3)
> I can take it, but I need to know where should the strings be put? Vivien?

Firefox usually use a preference for such things (http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#856) The value of the preference contains some variables that are replaced at run time.

But reading comment 0 it seems like removing the en-US part of the url is enough.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Axel Hecht [:Pike] from comment #1)
> I request this to block basecamp. The FAQ link is just wrong, AFAICT.

Waiting for Grace answer here.
> 
> Please change the urls to be locale agnostic, and remove them from the
> .properties files and move them to code. That's taking the most advantage
> out of the infrastructure we have server side, and allows us to adjust the
> URLs for the FAQ for example to something more focused once we have that.

How does moving them out of the properties change anything on the infrastructure on the server side?

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/7202

Let's not worry about the official/unofficial thing in this bug then.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Vivien Nicolas (:vingtetun) from comment #9)
> (In reply to Axel Hecht [:Pike] from comment #1)
> > I request this to block basecamp. The FAQ link is just wrong, AFAICT.
> 
> Waiting for Grace answer here.

Is http://support.mozilla.org/products/firefox-os the right address? If so you could take my patch as-is.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 695938 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7202

r=me. Powerful l10n lib I never know it has the ability to replace DOM attribute \O/ https://github.com/mozilla-b2g/gaia/blob/master/shared/js/l10n.js#L242

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 695938 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7202

Sounds good enough for me. Grace if you're unhappy please open a followup bug.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/5d0df4bd2d6ac8c82c7698cc23162f98b6403721

Comment 15

[Chris Kreinbring [:CKreinbring]]

In Unagi build 20121231070201, the URL for the User Guide page is http://support.mozilla.org/en-US/products/firefox-os?as=u&utm_source=inproduct.  This is the case even after the language and location are set to a non-US location.  Reopening.

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to ckreinbring from comment #15)
> In Unagi build 20121231070201, the URL for the User Guide page is
> http://support.mozilla.org/en-US/products/firefox-
> os?as=u&utm_source=inproduct.  This is the case even after the language and
> location are set to a non-US location.  Reopening.

Please file another bug and clearly states where the link is.

This bug is about the "Support" and "FAQ" link in the Browser app.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #16)
> (In reply to ckreinbring from comment #15)
> > In Unagi build 20121231070201, the URL for the User Guide page is
> > http://support.mozilla.org/en-US/products/firefox-
> > os?as=u&utm_source=inproduct.  This is the case even after the language and
> > location are set to a non-US location.  Reopening.
> 
> Please file another bug and clearly states where the link is.
> 
> This bug is about the "Support" and "FAQ" link in the Browser app.

Bug 825831 filed.

Comment 18

[sarsenyev]

Verified it's fixed on "Unagi"
Build ID:20130114073222

Mozilla support page changes language according to the language chosen in "Language" in the settings.