823087 - Gaia should not use text-transform: capitalize; in CSS

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Guillermo López :willyaranda (probably SLOW response)]

Some of the locales, for example in Spanish, is totally incorrect to Capitalize First Letter in each word. (This is shown on "Passcode lockscreen")

It's on:

- apps/communications/ftu/css/style.css:76
- apps/homescreen/everything.me/modules/Shortcuts/Shortcuts.css:129 and 148
- apps/homescreen/everything.me/modules/SmartFolder/SmartFolder.css:60
- apps/homescreen/style/grid.css:80
- apps/system/style/lockscreen/lockscreen.css:132

Comment 1

[Cristian Rodriguez (:crdlc)]

I can change it here

apps/homescreen/style/grid.css

It was implemented in order to show the app name with the first letter capitalized

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Lockscreen problem

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Homescreen, FTE and lockscreen

It fixes the grid css in homescreen

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Shortcuts screenshot

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Smartfolder screenshot

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Guillermo, the css rules in Evme are all of titles - not sentences/phrases  - therefore I believe they can be left unchanged.
Attached the related images.

Comment 7

[Guillermo López :willyaranda (probably SLOW response)]

Ran, if those CSS rules are not applied to a localizable element, that's fine.

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

Vivien, can you take a look at comment #0 --> apps/system/style/lockscreen/lockscreen.css:132

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

You're right Guillermo, they aren't.

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

Comment on attachment 694267 [details]
Homescreen, FTE and lockscreen

Per conversation with Cristian, this applies to app names on homescreen.

So, if we have translated "Cost control" to "Control de consumos", it is transformed to "Control De Consumos", which is not good for, at least, Spanish.

I can give a r+, but asking for review from Axel too.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 694267 [details]
Homescreen, FTE and lockscreen

Super trivial change. As a module peer I can give you an r+ on this. If some one fixes the lock screen case I can also give that an r+.

However, to get this landed, we need approval to module owner/release drivers to reduce the risk. Please fill out the form here:

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

willyaranda, thank you for file the bug! It's pretty insensitive of devs (including me) to use this broken CSS feature, sorry about that. Would you like to submit a pull request and patch Gaia?

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 694267 [details]
Homescreen, FTE and lockscreen

Yes, don't to text transforms on translated text.

We may also not want to do that for text we get from the web, like changing other people's brand names to be Caps, like Mozilla vs mozilla.
Also, the Caps might not be applicable in a localized version of fx os at all.

Comment 13

[Guillermo López :willyaranda (probably SLOW response)]

So we should delete all references of this CSS feature completely from Gaia, including Ev.me? (see comment #6 and comment #9)

Comment 14

[Axel Hecht [:Pike]]

I suspect that it's having more down- than upsides most of the time, I'd vouch for yes, review and likely remove.

Comment 15

[Ran Ben Aharon [:ranbena] EverythingMe]

In comment #9 I meant that they aren't localized so it's ok to leave them as is.

Comment 16

[Guillermo López :willyaranda (probably SLOW response)]

Cristian, can you delete the references of "text-transform: capitalize;" on gaia except on ev.me on your PR?

Comment 17

[Cristian Rodriguez (:crdlc)]

ok friends

Comment 18

[Cristian Rodriguez (:crdlc)]

done

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 694267 [details]
Homescreen, FTE and lockscreen

r+ commit 201e1ba, thanks

Comment 20

[Guillermo López :willyaranda (probably SLOW response)]

https://github.com/mozilla-b2g/gaia/pull/7102 updated

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: Spanish, and other languages, are affected since capitalization is not correct
Testing completed: Lockscreen, FTU and homescreen grid
Risk to taking this patch (and alternatives if risky): None.

Comment 21

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 694267 [details]
Homescreen, FTE and lockscreen

Sounds a low risk patch. Taking.

Comment 22

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/18b483281d0ea6d3a374eafac366cd942da87d51

Comment 23

[amiller]

Device: Unagi
Build: 20130102070202
Improper capitalization does not occur for different languages on this build.