823094 - Test invalid permissions loading

Status: RESOLVED FIXED

(Core :: Permission Manager, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Unfortunately, we can't test that on debug because we want to assert when we find an invalid permission (because it should not happen) but a NS_ASSERTION stops the test run and make it fail.

It should test bug 823093 and bug 814554.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 693917 [details] [diff] [review]
Patch

Review of attachment 693917 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/test/unit/test_permmanager_load_invalid_entries.js
@@ +131,5 @@
> +  connection.executeSimpleSQL(
> +    "INSERT INTO moz_hosts " +
> +    "(id, host, type, permission, expireType, expireTime, appId, isInBrowserElement) " +
> +    "VALUES (16, '42', '16', 1, 0, 0, 0, 10)"
> +  );

I would probably have used a loop or some such so that the values were more compressed together. But I'm fine either way.

Comment 2

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ce064030396

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ce064030396