Closed Bug 823094 Opened 9 years ago Closed 9 years ago

Test invalid permissions loading

Categories

(Core :: Permission Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Unfortunately, we can't test that on debug because we want to assert when we find an invalid permission (because it should not happen) but a NS_ASSERTION stops the test run and make it fail.

It should test bug 823093 and bug 814554.
Attachment #693917 - Flags: review?(jonas)
Comment on attachment 693917 [details] [diff] [review]
Patch

Review of attachment 693917 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/test/unit/test_permmanager_load_invalid_entries.js
@@ +131,5 @@
> +  connection.executeSimpleSQL(
> +    "INSERT INTO moz_hosts " +
> +    "(id, host, type, permission, expireType, expireTime, appId, isInBrowserElement) " +
> +    "VALUES (16, '42', '16', 1, 0, 0, 0, 10)"
> +  );

I would probably have used a loop or some such so that the values were more compressed together. But I'm fine either way.
Attachment #693917 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/0ce064030396
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.