Closed Bug 823095 Opened 11 years ago Closed 11 years ago

Better pinstripe theme-ing for new Downloads View in Places

Categories

(Firefox :: Bookmarks & History, defect, P1)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 20

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v1
1.76 KB, patch
asaf
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #822258 +++

The new Downloads View in places landed in bug 675902 with pinstripe theme-ing, but that theme-ing needs some love.
Attached patch Patch v1 (obsolete) — — Splinter Review 
Tweaks the current pinstripe theme to match the work I started in bug 822258 for winstripe.
Assignee: nobody → mconley
Attachment #693961 - Flags: review?(mak77)
bug 815352 part 1 landed and, provided it sticks to the tree, moves some of the style files, so this likely needs an unbitrot.
Comment on attachment 693961 [details] [diff] [review]
Patch v1

Starting to de-bitrot this.
Attachment #693961 - Attachment is obsolete: true
Attachment #693961 - Flags: review?(mak77)
Attached patch Patch v1 — — Splinter Review 

    
  

        Attachment #695766 -
        Flags: review?(mak77)

    
    

    
  
Comment on attachment 695766 [details] [diff] [review]
Patch v1

>+#downloadsRichListBox {
>+  -moz-appearance: none;

Add a comment here explaining that the default "listbox" appearance comes with the unwanted margin.

        Attachment #695766 -
        Flags: review?(mak77) → review+

    
    

    
  
Done. Also, added the same comment to winstripe and gnomestripe, since we do the same thing there.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3de40b952c58

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3de40b952c58
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Depends on: 854555

          You need to log in
          before you can comment on or make changes to this bug.