Closed
Bug 823100
Opened 12 years ago
Closed 11 years ago
ssl_NewSocket should init ephemeralECDHKeyPair to NULL
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.15
People
(Reporter: KaiE, Unassigned)
Details
Attachments
(1 file)
|
348 bytes,
patch
|
ryan.sleevi
:
review+
|
Details | Diff | Splinter Review |
ssl_NewSocket inits most members, but doesn't init ephemeralECDHKeyPair. It should init it to NULL.
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #693925 -
Flags: review?(ryan.sleevi)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 693925 [details] [diff] [review] patch v1 Review of attachment 693925 [details] [diff] [review]: ----------------------------------------------------------------- We haven't run into this being an issue in practice, due to the PORT_ZAlloc() call, but I agree that making this change makes it clear and is consistent with the rest of the initialization code in ssl_NewSocket.
Attachment #693925 -
Flags: review?(ryan.sleevi) → review+
|
|
Reporter | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 3•11 years ago
|
||
checked in: https://hg.mozilla.org/projects/nss//rev/7e86fab0cd5d0642570a06765c45b20a6eecdf85
Keywords: checkin-needed
Target Milestone: --- → 3.14.4
|
|
Reporter | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•11 years ago
|
Target Milestone: 3.14.4 → 3.15
You need to log in
before you can comment on or make changes to this bug.
Description
•