823103 - Some syntax warning about debugger-controller.js/debugger-view.js when opening debugger.

Status: RESOLVED INVALID

(DevTools :: Debugger, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

[Environment]
* http://hg.mozilla.org/mozilla-central/rev/bfd85c9652fa

[Result]
---------------------
Warning: SyntaxError: test for equality (==) mistyped as assignment (=)?
Source File: chrome://browser/content/debugger-controller.js
Line: 679, Column: 45
Source Code:
    } while (environment = environment.parent); 
--------------------
Warning: SyntaxError: test for equality (==) mistyped as assignment (=)?
Source File: chrome://browser/content/debugger-view.js
Line: 1238, Column: 39
Source Code:
    while (firstChild = list.firstChild) { 
--------------------

[More Info]
Does these notation have some special reason? Or Are these careless mistake?

Comment 1

[Victor Porof [:vporof][:vp]]

These are what they're supposed to be -- assignments. Probably adding another pair of parans would silence the warning; something like:
> while ((environment = environment.parent))

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

I don't think we should abide by the non-standard strict mode warnings.