823133 - Calendar is not fully localizable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Guillermo López :willyaranda (probably SLOW response)]

It says some strings in English, and also starts the week always on Sunday.

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

Latest gaia shows:

1) Month view starts in Sunday, which is totally wrong for Spanish. There is no way to change it. Also, there is a "VIERNES ENERO 2013" which do not make sense.

2) Week view  shows a "ALLDAY" on top-left. Title is "month year", in Spanish we should add a "de" between those two words.

3) Day view show the same "ALLDAY" on top-left. Title is "weekday month day", we should be able to change to "weekday, day de month".


Nominating: this show strings in English and not the locale chosen by the user.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The fix should have land this morning for it. Can you check again?

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

Ok, some of them are fixed, like:

1) Month view has a proper localized content at the bottom, but lacks the first part, but it's not bad, we can ship with it. Also, starts on Sunday and not on Monday.

2) Fixed the "ALLDAY", but still the "enero 2013" should be localizable: "enero _de_ 2013" sounds better.

3) Fixes the "ALLDAY" string, but not the title, and this sounds really bad for Spanish.

Comment 5

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7509

Pointer to Github pull-request

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 700467 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7509

This is a good improvement but its important to note when changing the local the order of week days is not changed until scrolling to a new frame. This is not perfectly ideal but should serve the majority of needs.

Comment 7

[Axel Hecht [:Pike]]

I'm struggling to map the two name sets to another:

# Title in header of week/month/day views.
month-scale-format=%B %Y
day-scale-format=%A %B %e
single-month-scale-format=%B 

Can we make the IDs here closer to how the strings are used? Right now, they're rather technical jargon about what the code does at the point, IMHO.

Comment 8

[Fabien Cazenave [:kaze]]

Comment on attachment 700467 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7509

r=me, though I agree with Pike the date formats are not very self-explanatory.

Please provide some context / explanation for the three new formats — a comment in the calendar.*.properties file would be fine. Thanks!

Comment 9

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/gaia/commit/b3ba83451ae0d995bd74175426f399c896b15210

I updated the name of the properties and added some more comments to explain what they do.