823191 - DeviceStorage enumerate doesn't see files with 0060 perms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dave Hylands [:dhylands]]

After applying attachment 693997 [details] [diff] [review] then the Gallery and Music apps no longer see files on the sdcard.

There are 2 reasons (that I can think of) which might be happening:

1 - The enumeration is happening in the child process (which would no longer have access)

2 - Even though the parent is running as root, it may still need to be a member of the sdcard_rw group in order to see the files (although I would have expected that if the parent process were using "other" priviledge then it shouldn't have been able to write anything - so my bet is still on 1)

Comment 1

[Dave Hylands [:dhylands]]

noming since this blocks a blocker

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Enumeration should be happening in the parent process already. So my guess is that the problem is the #2 one.

Comment 3

[Dave Hylands [:dhylands]]

Another possibility is that maybe the mediadb stuff is trying to directly open the files to parse the metatag info?

Comment 4

[Dave Hylands [:dhylands]]

It seems that DeviceStorage is returning the list of files fine.

The failure is occuring in mediadb.js here:

    function parseMetadata(file, filename) {
      if (!file.lastModifiedDate) {

and this causes:

[JavaScript Error: "NS_ERROR_FILE_ACCESS_DENIED: Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIDOMFile.lastModifiedDate]" {file: "app://gallery.b2g.hylands.org/shared/js/mediadb.js" line: 1189}]

So the file access is happening from the content process which fails because there is no permission.

So either this needs to be remoted, or devicestorage needs to provide the information so that mediadb.js doesn't need to try and access the locally.

Comment 5

[Doug Turner (:dougt)]

file should be a remoted blob.  does file.length return without error?

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We use fstat in here right?

Comment 7

[Doug Turner (:dougt)]

unrelated.  the stat should happen in the parent process on the IO thread and be remoted down as part of the remote blob other meta info (like length).

Comment 8

[Doug Turner (:dougt)]

the problem is that the we do not remember the last modification date.  The blob is created without one.

Comment 9

[Doug Turner (:dougt)]

blocks a blocker, also pretty sure we can't ship w/o being able to use media files :)

Comment 10

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 11

[Doug Turner (:dougt)]

Continue() makes the call if it should execute Run() or dispatch to the parent process.

Comment 12

[Doug Turner (:dougt)]

works on device and locally.  sent to try, awaiting results.

Comment 13

[Doug Turner (:dougt)]

https://tbpl.mozilla.org/?tree=Try&rev=658ae50bd7f0

looks fine.

Comment 14

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/fb4836c277eb

Comment 15

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/41afb957cc8d

Comment 16

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/c0e2b887f96c