Closed Bug 823195 Opened 9 years ago Closed 9 years ago

virtualenv should use --no-site-packages by default

Categories

(Testing :: Marionette, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox20 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

RESOLVED FIXED
mozilla20
Tracking Status
firefox20 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: mdas, Assigned: mdas)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
I got bitten by this a few too many times. The virtual environment created by marionette shouldn't know about the system's site packages, and should rely only on what is set up for that environment.
Attachment #694003 - Flags: review?(jgriffin)
Comment on attachment 694003 [details] [diff] [review]
fix v1.0

Review of attachment 694003 [details] [diff] [review]:
-----------------------------------------------------------------

Totally agree, thanks!
Attachment #694003 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/2e0f54b2bbc4
Assignee: nobody → mdas
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
fwiw virtualenv set --no-site-packages as its default in 1.7 (released 30-11-2011) http://www.virtualenv.org/en/latest/news.html#id10
You need to log in before you can comment on or make changes to this bug.