Closed Bug 823333 Opened 12 years ago Closed 10 years ago

correct scripts to not push if nothing was changed

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: hwine, Unassigned)

References

Details

(Whiteboard: [re-vcs-sync]) 

This is no longer an optimization - it can mask real errors.

Currently, the code and error utilities ignore an exit code of '1' from hg push operations, as this is the status when there is nothing new to push (often because nothing new was pulled).

bug 822853 comment 2 shows a failed push due to changed hook behavior. That failed push also returns an exit code of '1', so the condition was undetected until a user reported it.
The safest approach will be to do the test for something to push just prior to the push. While skipping processing if there is nothing to pull would reduce overall CPU usage, as "self healing" code is added, there could be items to push even without a pull.
Whiteboard: [re-vcs-sync]
Product: mozilla.org → Release Engineering
* no one's working on this bug
* Pete's going to be working on porting to the new system

I'm going to wontfix; if we need to fix this in the legacy system, we can reopen.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.