823346 - [Bluetooth][Hfp] Updating status change of Battery level

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

To update Battery status change to connected HFP devices, we need to implement [4.7 Transfer of Battery Level Indication of AG], HFP spec 1.6.

This is a follow-up to bug 820157.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Notify observers when battery level changes

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 2(v1): Updating status change of Battery level in BluetoothHfpManager

Eric, please help to review Bluetooth part.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 698599 [details] [diff] [review]
Patch 1(v1): Notify observers when battery level changes

Mounir, not sure who shall be reviewer of the BatteryManager part. Please help to review or re-direct to the right person. Thanks.

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 698599 [details] [diff] [review]
Patch 1(v1): Notify observers when battery level changes

Review of attachment 698599 [details] [diff] [review]:
-----------------------------------------------------------------

You actually don't need to add that. You just need to register for battery observing with Hal (See RegisterBatteryObserver in Hal.h).
You can see how to use it by looking at BatteryManager's code.

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v2): Register battery observing with Hal and update battery status

Comment 6

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 699548 [details] [diff] [review]
Patch 1(v2): Register battery observing with Hal and update battery status

Review of attachment 699548 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, sorry for the late review. :)

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version - Updating status change of Battery level, r=echou

try:
https://tbpl.mozilla.org/?tree=Try&rev=4d46fad9c2fb
https://tbpl.mozilla.org/?tree=Try&rev=51b9c4f47042

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85a82ac65bd4

Comment 9

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/85a82ac65bd4

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Please nominated for uplift approval with a risk assessment.

Comment 11

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: for b2g18, r=echou

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): no
User impact if declined: would miss a Bluetooth HFP feature which is neccesary for certification
Testing completed: mozilla-central
Risk to taking this patch (and alternatives if risky): Fairly low. What we've done in this patch is listening to the battery status and updating to remote device.
String or UUID changes made by this patch: no

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 729434 [details] [diff] [review]
patch 1: for b2g18, r=echou

Approving low risk HFB patches to bring us closer to spec.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/aa984c73484d

Comment 14

[Kai-Chih Hu [:khu]]

This bug(and other 9 bugs) block Bluetooth certification. So, these bugs need to be marked as tef+ and landed to v1.0.1 in order to pass Bluetooth certification: 

bug 827255
bug 827212
bug 827266
bug 828175
bug 823346
bug 827230
bug 828798
bug 835740
bug 846647
bug 828160

So, mark these bugs as tef?. These fixes have some dependency and it would be better to have them landed in a specific order. Gina has a good view on this.

Comment 15

[Gina Yeh [:gyeh] [:ginayeh]]

I recommend to land these patches in the following order:

01. bug827204
02. bug827255
03. bug823346
04. bug827230
05. bug828798
06. bug827212, patch 1
06. bug827212, patch 2
07. bug827266
08. bug828175
09. bug846647
10. bug825861
11. bug825851
12. bug835740




I'm going to attach patches for b2g18_v1_0_1 for each bug. Please land them in the above order. There should be no conflict and feel free to let me know if I can be any help.

Comment 16

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: b2g18_v1_0_1 patch

Comment 17

[Alex Keybl [:akeybl]]

I suspect this hasn't been uplifted since v1.0.1 was still marked as wontfix.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/1a2608640658