823370 - [FTU] Hit "Import SIM contacts" multiple time will create duplicate contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[John Shih]

## Environment :
Unagi phone, daily build 2012-12-20
Build info: 
gaia master: 6b2782639208a52e070185750ef66421f67f0b2c
mozilla-b2g18 : 81b03770cbbc

## Repro :
1. Flash and boot the device
2. In the FTU, move to Import contacts
3. Hit Import from SIM multiple times

## Expected:
* There should be a protection mechanism or logic to only let one set of SIM contacts be imported

## Actual:
* There will be duplicate contacts be imported according to the hit times

Comment 1

[Jose Manuel Cantera]

Attachment: Pointer to GH PR 7107

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 

High

Testing completed: 
Risk to taking this patch (and alternatives if risky):

very low

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 694364 [details]
Pointer to GH PR 7107

Small and unrisky change that makes the product better.

a=me

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Does this patch solve the described problem?  It seems it will disable the button, but not prevent the same process being repeated later which will still result in multiple contacts being created.  See also bug 823372 and bug 813732 for likely duplicates.

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 694364 [details]
Pointer to GH PR 7107

till the addressed comments are fixed :)

Comment 5

[Fernando Campo (:fcampo)]

(In reply to Mark Hammond (:markh) from comment #3)
> Does this patch solve the described problem?  It seems it will disable the
> button, but not prevent the same process being repeated later which will
> still result in multiple contacts being created.  See also bug 823372 and
> bug 813732 for likely duplicates.

My understanding is that we have two different problems here.

One is the multiple clicks on the 'Import' button while being on the same screen or even during the importing process. This could be accidental, or due to bad refreshing of the messages, and that is what should be fixed by this patch.

On the other hand, if the user import the contacts properly, finishes the FTU, and later goes to contacts click again the import button, then is a deliberate action, not an user error, and that is known and explained in https://bugzilla.mozilla.org/show_bug.cgi?id=813732#c2, being a limitation on contact-validation.

Comment 6

[Fernando Campo (:fcampo)]

Patch updated on github, works fine now, so r=me. Thanks Jose

Comment 7

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/1172f87e368e4b01f8ad8f30b5ef9f78a1edc1a3