823375 - Add "BUILD_WITH_ARM_NEON" when the compiler supports neon instructions and the cflags has "mfpu=neon"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[StevenLee[:slee]]

Attachment: patch

We already have "HAVE_ARM_NEON" flag. It means the compiler supports neon instruction. On some platforms, such as emulator, compiler supports neon, but the target does not. We need a flag for it.

Comment 1

[StevenLee[:slee]]

Attachment: patch v2

Remove debug message.

Comment 2

[StevenLee[:slee]]

Hi dmose,
I think I misunderstood something. I found that I cannot cancel the request. Please ignore this request. Sorry for the inconvenience.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

No worries; I'm unable to cancel the request either.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

I made a similar patch for Android ARMv6, before finding this bug:
https://hg.mozilla.org/try/rev/ce27dccc07bc
based on the knowledge that the gyp buildsystem will turn on NEON for ARMv7.

Your patch may be better, but that controls whether we turn on fpu=neon? It's not necessarily linked to what the gypfile does, no? Because that one will set if flags after your configure runs.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Holy typing mistakes.

...what controls...set its flags...

Comment 6

[Mike Hommey [:glandium]]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #4)
> I made a similar patch for Android ARMv6, before finding this bug:
> https://hg.mozilla.org/try/rev/ce27dccc07bc
> based on the knowledge that the gyp buildsystem will turn on NEON for ARMv7.

I prefer this approach, but you don't want the AC_DEFINE. Please also add that this matches media/webrtc/trunk/webrtc/build/common.gypi.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Only enable NEON on ARMv7+

Comment 8

[Gian-Carlo Pascutto [:gcp]]

https://bugzilla.mozilla.org/show_bug.cgi?id=823375

Comment 9

[Gian-Carlo Pascutto [:gcp]]

Oops:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4078fd282b4d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4078fd282b4d