Closed Bug 823375 Opened 7 years ago Closed 7 years ago
_WITH _ARM _NEON" when the compiler supports neon instructions and the cflags has "mfpu=neon"
We already have "HAVE_ARM_NEON" flag. It means the compiler supports neon instruction. On some platforms, such as emulator, compiler supports neon, but the target does not. We need a flag for it.
Remove debug message.
Hi dmose, I think I misunderstood something. I found that I cannot cancel the request. Please ignore this request. Sorry for the inconvenience.
No worries; I'm unable to cancel the request either.
I made a similar patch for Android ARMv6, before finding this bug: https://hg.mozilla.org/try/rev/ce27dccc07bc based on the knowledge that the gyp buildsystem will turn on NEON for ARMv7. Your patch may be better, but that controls whether we turn on fpu=neon? It's not necessarily linked to what the gypfile does, no? Because that one will set if flags after your configure runs.
Holy typing mistakes. ...what controls...set its flags...
(In reply to Gian-Carlo Pascutto (:gcp) from comment #4) > I made a similar patch for Android ARMv6, before finding this bug: > https://hg.mozilla.org/try/rev/ce27dccc07bc > based on the knowledge that the gyp buildsystem will turn on NEON for ARMv7. I prefer this approach, but you don't want the AC_DEFINE. Please also add that this matches media/webrtc/trunk/webrtc/build/common.gypi.
Attachment #736293 - Flags: review?(mh+mozilla) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.