Closed Bug 823375 Opened 7 years ago Closed 7 years ago

Add "BUILD_WITH_ARM_NEON" when the compiler supports neon instructions and the cflags has "mfpu=neon"

Categories

(Firefox Build System :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: slee, Assigned: gcp)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
We already have "HAVE_ARM_NEON" flag. It means the compiler supports neon instruction. On some platforms, such as emulator, compiler supports neon, but the target does not. We need a flag for it.
Attachment #694214 - Flags: review?(dmose)
Attached patch patch v2 (obsolete) — Splinter Review
Remove debug message.
Attachment #694214 - Attachment is obsolete: true
Attachment #694214 - Flags: review?(dmose)
Attachment #694238 - Flags: review?(dmose)
Hi dmose,
I think I misunderstood something. I found that I cannot cancel the request. Please ignore this request. Sorry for the inconvenience.
No worries; I'm unable to cancel the request either.
Attachment #694238 - Attachment filename: stuff
Attachment #694238 - Flags: review?(dmose)
I made a similar patch for Android ARMv6, before finding this bug:
https://hg.mozilla.org/try/rev/ce27dccc07bc
based on the knowledge that the gyp buildsystem will turn on NEON for ARMv7.

Your patch may be better, but that controls whether we turn on fpu=neon? It's not necessarily linked to what the gypfile does, no? Because that one will set if flags after your configure runs.
Holy typing mistakes.

...what controls...set its flags...
Blocks: 835716
(In reply to Gian-Carlo Pascutto (:gcp) from comment #4)
> I made a similar patch for Android ARMv6, before finding this bug:
> https://hg.mozilla.org/try/rev/ce27dccc07bc
> based on the knowledge that the gyp buildsystem will turn on NEON for ARMv7.

I prefer this approach, but you don't want the AC_DEFINE. Please also add that this matches media/webrtc/trunk/webrtc/build/common.gypi.
Assignee: nobody → gpascutto
Attachment #694238 - Attachment is obsolete: true
Attachment #736293 - Flags: review?(mh+mozilla)
Attachment #736293 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/4078fd282b4d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.