Closed Bug 823423 Opened 7 years ago Closed 7 years ago

java.lang.IllegalStateException: Accessibility off. Did you forget to check that? at android.view.accessibility.AccessibilityManager.sendAccessibilityEvent(AccessibilityManager.java)

Categories

(Firefox for Android :: General, defect, critical)

ARM
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 21
Tracking Status
firefox18 --- affected
firefox20 --- affected

People

(Reporter: scoobidiver, Assigned: eeejay)

Details

(Keywords: crash, Whiteboard: [native-crash])

Crash Data

Attachments

(1 file, 1 obsolete file)

There are one crash in 20.0a1/20121218, bp-578cf76c-89ae-414c-8fa7-c026a2121219, and three crashes in 18.0b3, so bug 764051 is not fully fixed.

java.lang.IllegalStateException: Accessibility off. Did you forget to check that?
	at android.view.accessibility.AccessibilityManager.sendAccessibilityEvent(AccessibilityManager.java:216)
	at android.view.ViewRootImpl.requestSendAccessibilityEvent(ViewRootImpl.java:4561)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at org.mozilla.gecko.GeckoAccessibility$3.run(GeckoAccessibility.java:173)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4745)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalStateException%3A+Accessibility+off.+Did+you+forget+to+check+that%3F+at+android.view.accessibility.AccessibilityManager.sendAccessibilityEvent%28AccessibilityManager.java%29
Eitan, any move on this any time soon?
Comment on attachment 698800 [details] [diff] [review]
Don't send a11y scroll or announcement events if we a11y is not officially enabled.

Would it not be better to add:

if (!mEnabled)
    return;

here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoAccessibility.java#119

Also, mEnabled, mVirtualCursorNode and mEventMessage should be sEnabled, sVirtualCursorNode and sEventMessage.
Attachment #698800 - Flags: review?(blassey.bugs) → review-
Assignee: nobody → eitan
Good ideas. Here is a new patch.
Attachment #698800 - Attachment is obsolete: true
Attachment #700657 - Flags: review?(blassey.bugs)
Attachment #700657 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/31d8d897cf4b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
You need to log in before you can comment on or make changes to this bug.