823423 - java.lang.IllegalStateException: Accessibility off. Did you forget to check that? at android.view.accessibility.AccessibilityManager.sendAccessibilityEvent(AccessibilityManager.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There are one crash in 20.0a1/20121218, bp-578cf76c-89ae-414c-8fa7-c026a2121219, and three crashes in 18.0b3, so bug 764051 is not fully fixed.

java.lang.IllegalStateException: Accessibility off. Did you forget to check that?
	at android.view.accessibility.AccessibilityManager.sendAccessibilityEvent(AccessibilityManager.java:216)
	at android.view.ViewRootImpl.requestSendAccessibilityEvent(ViewRootImpl.java:4561)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at android.view.ViewGroup.requestSendAccessibilityEvent(ViewGroup.java:666)
	at org.mozilla.gecko.GeckoAccessibility$3.run(GeckoAccessibility.java:173)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4745)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalStateException%3A+Accessibility+off.+Did+you+forget+to+check+that%3F+at+android.view.accessibility.AccessibilityManager.sendAccessibilityEvent%28AccessibilityManager.java%29

Comment 1

[Marco Zehe (:MarcoZ)]

Eitan, any move on this any time soon?

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Don't send a11y scroll or announcement events if we a11y is not officially enabled.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 698800 [details] [diff] [review]
Don't send a11y scroll or announcement events if we a11y is not officially enabled.

Would it not be better to add:

if (!mEnabled)
    return;

here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoAccessibility.java#119

Also, mEnabled, mVirtualCursorNode and mEventMessage should be sEnabled, sVirtualCursorNode and sEventMessage.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 823423 - Don't send a11y scroll or announcement events if we a11y is not officially enabled.

Good ideas. Here is a new patch.

Comment 5

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31d8d897cf4b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/31d8d897cf4b

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/31d8d897cf4b

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/31d8d897cf4b