Fix 'Services.appshell', should be 'Services.appShell' (documentation was wrong)

RESOLVED FIXED in 2.1

Status

Calendar
Internal Components
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

({regression})

Trunk
regression

Details

Attachments

(1 attachment, 1 obsolete attachment)

http://mxr.mozilla.org/comm-central/source/calendar/resources/content/calendarService.js#119
has
w = Services.appshell.hiddenDOMWindow;
which should be
w = Services.appShell.hiddenDOMWindow;

The documentation was wrong on this :/. Upcoming patch.
Created attachment 694289 [details] [diff] [review]
Change Services.appshell to Services.appShell

You will have to transplant the patch to comm-aurora and comm-beta.
Attachment #694289 - Flags: review?(philipp)
Fallen, if you don't want to ship this bug in a week, this needs to be fixed/reviewed as soon as possible.
Flags: needinfo?(philipp)

Comment 3

4 years ago
The file doesn't seem to be shipped with Lightning, i.e. only Sunbird would be affected.
Comment on attachment 694289 [details] [diff] [review]
Change Services.appshell to Services.appShell

r=philipp
Attachment #694289 - Flags: review?(philipp) → review+
Flags: needinfo?(philipp)
Created attachment 698773 [details] [diff] [review]
Change Services.appshell to Services.appShell, r=philipp
Fallen: Should this be ported to the branches?
Keywords: checkin-needed
Whiteboard: [leave open for porting to branches]
Attachment #694289 - Attachment is obsolete: true
Comment on attachment 698773 [details] [diff] [review]
Change Services.appshell to Services.appShell, r=philipp

Sure, go ahead!
Attachment #698773 - Flags: approval-calendar-beta+
Attachment #698773 - Flags: approval-calendar-aurora+
(Its not really worth the effort to port to branches since its in Sunbird only, but it won't hurt)
https://hg.mozilla.org/comm-central/rev/a5ea04a91cec
Keywords: checkin-needed
https://hg.mozilla.org/releases/comm-aurora/rev/d65d5df382af
https://hg.mozilla.org/releases/comm-beta/rev/db200194fee4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [leave open for porting to branches]
Target Milestone: --- → 2.0

Updated

4 years ago
Target Milestone: 2.0 → 2.1
You need to log in before you can comment on or make changes to this bug.