Missing Message-ID header in invitation email

RESOLVED FIXED in 4.0.0.1

Status

Calendar
E-mail based Scheduling (iTIP/iMIP)
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Jan Hejl, Assigned: MakeMyDay)

Tracking

Trunk
4.0.0.1

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121129165506

Steps to reproduce:

Create invitation with users to be notified


Actual results:

Invitation email is missing Message-ID header


Expected results:

Invitation message should have Message-ID header.
Component: Lightning Only → E-mail based Scheduling (iTIP/iMIP)
(Assignee)

Comment 1

3 years ago
Confirming this is still an issue on current trunk.

When this get's fixed, one should consider to also add further headers as specified in the setting for the respective mail account (e.g. organization, reply-to address, returnReceipt, etc.). Adding a priority header set to the value of the vevent priority is also worth to think of. Last but not least setting a User-Agent header (prob. extend by the application name and version of Lightning) might make bug analysis little easier if related to imip/itip bugs.

The account related stuff mentioned above should also be considered to be added for mails composed for all/undecided attendees out of the event dialog.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: Lightning 1.9 → Sunbird 0.9
(Assignee)

Updated

3 years ago
Version: Sunbird 0.9 → Trunk
(Assignee)

Comment 2

2 years ago
Created attachment 8567635 [details] [diff] [review]
ImprovedMessageHeaderSupport-V1.diff

This patch adds the message-id to invitation mails and adds also organizer and sender's CN (based on the identity) to the mail headers of the same.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Attachment #8567635 - Flags: review?(philipp)
Comment on attachment 8567635 [details] [diff] [review]
ImprovedMessageHeaderSupport-V1.diff

Review of attachment 8567635 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/itip/calItipEmailTransport.js
@@ +304,5 @@
>                                                               "UTF-8",
>                                                               fieldNameLen,
>                                                               Components.interfaces.nsIMimeConverter.MIME_ENCODED_WORD_SIZE);
>              }
> +            

Added some whitespaces here.
Attachment #8567635 - Flags: review?(philipp) → review+
Pushed to comm-central changeset 11bbc7e7b180
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
There is a whitespace missing at https://hg.mozilla.org/comm-central/rev/11bbc7e7b180#l1.65
> cal.validateRecipientList(aIdentity.fullName + "<" + aIdentity.email + ">");
(Assignee)

Comment 6

2 years ago
Thanks for finding this. I will do a correction.
(Assignee)

Comment 7

2 years ago
Created attachment 8568080 [details] [diff] [review]
ImprovedMessageHeaderSupport-RegressionFix-V1.diff

Regression Fix, applying on top of the already checked in patch.

Beside the correction Archaeopteryx mentioned, I removed the User-Agent header, since bug 1037978 is not yet checked in.
Attachment #8568080 - Flags: review?(philipp)
Attachment #8568080 - Flags: review?(philipp) → review+
Attachment #8568080 - Flags: approval-calendar-aurora+
(Assignee)

Comment 8

2 years ago
Regression fix pushed to cc: https://hg.mozilla.org/comm-central/rev/2717b1d486cf

It still needs to be pushed to Aurora.
https://hg.mozilla.org/releases/comm-aurora/rev/a776bf569c09
You need to log in before you can comment on or make changes to this bug.