823499 - JavaScript error: this.editor is null when opening a popup window

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Open Attachment 632505 [details]
2. Click on "Open an empty window"

Results:
This error appears in the Error Console:
Timestamp: 20.12.2012 15:04:00
Error: TypeError: this.editor is null
Source File: chrome://navigator/content/urlbarBindings.xml
Line: 104

Comment 1

[Frank Wein [:mcsmurf]]

This checkin added the code that throws the error: http://hg.mozilla.org/comm-central/rev/5cb1917f9106 => Bug 689139

Comment 2

[Phoenix]

Adding
if (!this.editor)
  return;
before that should be enough?

Comment 3

[Phoenix]

Attachment: Just check if this.editor is not set

As nobody objected...

Comment 4

[[e-mail]]

Comment on attachment 696077 [details] [diff] [review]
Just check if this.editor is not set

[I wonder whether it's moving the test to the callers that care about it (focus definitely doesn't for instance).]

>+          if (!this.editor)
>+            return;
Nit: needs a blank line after here.

Comment 5

[Phoenix]

Attachment: Just check if this.editor is not set v2

Added newline, carrying r+

Comment 6

[Frank Wein [:mcsmurf]]

Patch does not apply, I'll fix manually:
$ hg qpush -v
applying bug-823499-v2.patch
patching file suite/browser/urlbarBindings.xml
bad hunk #1 @@ -96,16 +96,18 @@
 (16 16 19 18)
patch failed, rejects left in working dir
errors during apply, please fix and refresh bug-823499-v2.patch

Comment 7

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/53cb7687277f