823547 - Store the snippets version along with the snippets

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak]]

On snippets version bump, if we fail to cache the new snippets, we fallback to the cached ones, that are an old unsupported version.
We should store the version along with the snippets, so that we clear the cache if it's outdated.

Comment 1

[Marco Bonardo [:mak]]

While writing tests for this, I found the current browser_aboutHome.js test wrongly relies on bug 790934, or better, it relies on the fact we set the attributes twice!
I'm trying to fix it.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

applies on top of the patch bug 820834.

When we bump the snippets version, this ensures we don't try to reuse a cached old version.

Unfortunately it's not 100% safe due to https://bugzilla.mozilla.org/show_bug.cgi?id=820834#c16 but that case should not be hit by final users (their browser should never ask for a future version).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 713640 [details] [diff] [review]
patch v1.0

Hoping Drew can help with review here.

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 713640 [details] [diff] [review]
patch v1.0

Review of attachment 713640 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/browser_aboutHome.js
@@ +171,5 @@
> +
> +    let snippetsElt = doc.getElementById("snippets");
> +    ok(snippetsElt, "Found snippets element");
> +    is(snippetsElt.getElementsByTagName("span").length, 1,
> +       "A default snippet is visible.");

"Visible" sounds like the wrong word, since this doesn't actually check the span's visibility.  "Present"?

@@ +194,5 @@
> +    let doc = gBrowser.selectedTab.linkedBrowser.contentDocument;
> +
> +    let snippetsElt = doc.getElementById("snippets");
> +    ok(snippetsElt, "Found snippets element");
> +    is(snippetsElt.innerHTML, "test", "Cached snippet is visible.");

Here too.

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac2581b910b6

Comment 6

[Marco Bonardo [:mak]]

backed out for bc failures
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bccbdd03dea

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fea3c18dfd7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1fea3c18dfd7