823588 - [Video] Unsupported Video files formats are not displayed with an error in Video App's File Browser

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[:CSchmoeckel]

Summary: After loading an unsupported video file onto the device, the file cannot be located in the Video App's File Browser.   

Steps: 1. Have an unsupported video file ready on the PC (ex.: http://support.apple.com/kb/HT1425)
2. Connect the phone to the computer via USB
3. Move the video file into the phone's Video folder
4. Disconnect the phone
5. Launch the video app

Result: The unsupported video file does not appear in the File Browser

Expected Result: Unsupported video files are displayed in the File Browser of the Video App with an error message. 

Build: 20121217070202  
This issue fails test case #3662 - [Video] Unsupported videos added to the video playlist are marked indicating the error

Comment 1

[cbarker]

Test Run 2
Issue still occurs on Unagi in Build 20130104070203

Comment 2

[Cody Roesch [:croesch]]

UCID videoplay-020
Testcase can be found here https://moztrap.mozilla.org/results/case/61055/

Comment 3

[:CSchmoeckel]

Unsupported video files still do not show up in the Video Player browser and have no invalid file type error displayed. 
Build ID: 20130130070201
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb
Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9

Comment 4

[Deepa Subramanian]

Unsupported video files still do not show up in the Video Player browser and have no invalid file type error displayed. 

Unagi Build ID: 20130225070200
Kernel: Dec 5
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6
UCID: Videoplay-020
Test case ID: https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=3662

Comment 5

[Nick Davidson]

in reference to comment 4

Test Case # 3662
UCID: Videoplay-020

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=3662

Comment 6

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Need a requirements check on this one

Comment 7

[amiller]

UCID: Videoplay-020
As a user, I want videos in unsupported formats to be listed with an error indicator and details about what's wrong with the format and how I might fix it, so that I'm not confused about why a file I placed on the card is not appearing.

Comment 8

[John Hammink]

Requirement states the video should be listed.  Current behavior is that it is not.  Removing 'qa wanted'.

Comment 9

[sarsenyev]

Environmental  Variables:
Inari Build ID: 20130416070200
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia: c883af5ecd0998f78d9aaa4c2337c842e1dbb5a0

The same issue reproduces on "Inari" device.
According to the test case ID: 4453, The unsupported files shouldn't appear in the video list.
https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=4453

The test case ID:3662 says the unsupported files should appear in the video list.
https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=3662

One of these test cases are invalid and need to be invalidated or updated

Comment 10

[sarsenyev]

UCID:videoplay-020

Comment 11

[Sarah Parsons]

Attachment: logcat

Comment 12

[:CSchmoeckel]

In MozTrap disabled TC#4453 - [Video] Video List View - Do not display unsupported video formats

This test case uses an old and removed UCID: videoplay-001

Comment 13

[John Hammink]

What is the correct UX behavior for this case?  Let me know so I can either koi? nom it or remove the referring testcases altogether.

Comment 14

[Stephany Wilkes]

Flagging Rob on this one since Media is his domain, though UX is still prioritizing blockers.

Comment 15

[Sotaro Ikeda [:sotaro]]

Video thumbnail generation API(Bug 873959) will be implemented in future. When it is implemented, some hw is going to use different video codec for thumbnail generation and video playback. There could be a case that thumbnail generation failed, but play back is possible.
For example, normal android's sw codec can decode only H.264 baseline profile.

Comment 16

[Angela Hubenya]

Test case 3662 disabled for v1.2 until bug 873959 is implemented.

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

I've some personal feeling about this issue at:

https://groups.google.com/forum/#!topic/mozilla.dev.gaia/l8R_nI8Dsvc

For short, I don't think I should be punished when I follow the public information to put a valid MP4 on my phone. It's totally different with the situations that I put some obvious unplayable files like MKV or RMVB.

I said "punished" because as an ordinary user, I have no chance to know what's happened. All things I know is my MP4 file, even I'm sure it's encoded with H264+AAC codec (slightly beyond a ordinary user's knowledge), it just won't even show in the playlist. This is very confused and frustrated.

*NI because David Flanagan suggested me that "I recommend that you file a bug and set needinfo for Chris Lam (the new UX designer for Video) and also John Hu.  Implementing what you suggest should not be too hard, (though it is complicated by the fact that the .mp4 extension can be music or video, so the sdcard scanning process has to divide files into three categories: playable video, unplayable video and not-a-video.  (Currently unplayable videos get lumped with not-a-video files and just don't show up.)"

Comment 18

[John Hu [:johnhu][:johu][:醬糊小弟]]

I can implement that once Chris gives us some suggestion about this case.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: can_play_on_Nexus4

One of the subtle part of MP4 issue is it depends on device, even for FirefoxOS.
This video is a Nexus4 running FirefoxOS (Gecko 26, v1.2). It can show and play as normal.

Comment 20

[Chris Lam]

Hey all,

Let's show the unsupported videos in the list.

Comment 21

[John Hu [:johnhu][:johu][:醬糊小弟]]

Chris,

May you give us some wireframe when we meet unsupported videos??

Comment 22

[Russ Nicoletti [:russn]]

Regarding comment# 17, I've looked into the ability to distinguish between not-a-video and unplayable vidoes. I'm not sure how we're going to do it. Currently, if we discovery a video is not playable, we don't try to load it. If we say an unplayable video is a video, we will try to load it and we will fail (at least that is my experience while testing with mp4 and mov -- quicktime -- files). At that point, there is an issue distinguishing between a valid but unplayable video and a corrupt video (we detect corrupt videos by detecting an error when loading the video).

I suppose we can simply not load unplayable videos since we won't be able to generate a thumbnail for them anyway.

Comment 23

[Hema Koka [:hema]]

NI jsavory for ux input

Comment 24

[John Hu [:johnhu][:johu][:醬糊小弟]]

(In reply to Russ Nicoletti [:russn] from comment #22)
> Regarding comment# 17, I've looked into the ability to distinguish between
> not-a-video and unplayable vidoes. I'm not sure how we're going to do it.

Currently, we don't know if a video is an unplayable or not-a-video because we view them as unplayable videos. And the definition of not-a-video is hard to define because we use file extension to enumerate all video files. And all files with valid extensions are tried to load by video element. Here is an example: When a plain text file ending with .mp4, we will try to load it with offscreen video element. If onerror is fired, we view this file as an unplayable video file just because it's extension is mp4 and is unplayable by video element.

There is another case that we can load the video file to video element but cannot draw it on the canvas, bug 869289 comment 3. In this case, we view this file as a playable video file but use a default image to be its thumbnail.

Comment 25

[Jacqueline Savory [:jsavory] UX]

Attachment: UnsupportedVideo.pdf

Sorry for the (very) long delay on this one. I've attached a mini spec that Katie put together, which will hopefully answer any UX questions. If this bug is still valid, feel free to needinfo me again if there are further questions.

Comment 26

[BMO Automation]

Firefox OS is not being worked on