Create a template for TreeStatus logs

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: emorley, Assigned: warunsl)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
This is fairly low priority, but currently logs are output without a template (https://treestatus.mozilla.org/mozilla-central/logs) and as such don't really offer much over just using https://treestatus.mozilla.org/mozilla-central/logs?format=json

Also, https://treestatus.mozilla.org/mozilla-central shows log entries, so maybe we can just use that?
Product: Webtools → Tree Management
(Assignee)

Comment 1

4 years ago
Looks like https://treestatus.mozilla.org/mozilla-central and https://treestatus.mozilla.org/mozilla-central/logs output the same information, except that the former uses a template. Why not redirect /tree/logs to /tree? 

Am I overlooking something?
(Assignee)

Updated

4 years ago
Flags: needinfo?(emorley)
(Reporter)

Comment 2

4 years ago
So there is a difference in the json output:
https://treestatus.mozilla.org/mozilla-central?format=json
https://treestatus.mozilla.org/mozilla-central/logs?format=json

And I think that is desirable, since people can decide whether they just need the current state, or history.

I think really the end result should be:
"Add template to tree/logs, and make the main tree page only show the last N log entries"

This bug is the first part of that, we can either just do that for now (and have another bug for making the https://treestatus.mozilla.org/mozilla-central page only show a short summary of history (with https://treestatus.mozilla.org/mozilla-central/logs being the full history), or do both here - is up to you :-)
Flags: needinfo?(emorley)
(Assignee)

Comment 3

4 years ago
Created attachment 8523311 [details] [review]
Bug 823616 - Create a template for TreeStatus logs; r=edmorley

Changes:
1. Created a template file 'treelogs.html' for HTML view for /tree/logs
2. Limited the number of log entries in /tree to 5. This could be changed if we think 5 is too low
3. Modified the view definition for /tree/logs to render the template
Attachment #8523311 - Flags: review?(emorley)
Comment on attachment 8523311 [details] [review]
Bug 823616 - Create a template for TreeStatus logs; r=edmorley

looks good to me - I merged it upstream
Attachment #8523311 - Flags: review?(emorley) → review+
(Reporter)

Comment 5

4 years ago
https://github.com/mozilla/treestatus/commit/4464faa2631d48eaaf05535736cb6ef947076b7a
Assignee: nobody → warunsl
Status: NEW → ASSIGNED
(Reporter)

Comment 6

4 years ago
This looks pretty good on dev:
https://treestatus-dev.allizom.org/mozilla-aurora
https://treestatus-dev.allizom.org/mozilla-aurora/logs

The only changes I think it might need, is to add a link to the /logs page from the tree page. ie: Below the 5 most recent changes, add a link called "Full log", "More..." or something similar.

I wonder as well whether it would be better to call the heading on the tree page "Recent Changes" rather than "Summary"?
(Assignee)

Comment 7

4 years ago
I think your suggestions would look good. How do I go about making the suggested changes when my PR is merged already?
Flags: needinfo?(emorley)
(Reporter)

Comment 8

4 years ago
(In reply to shaktimaan from comment #7)
> I think your suggestions would look good. How do I go about making the
> suggested changes when my PR is merged already?

If you create another PR, and add the link to that as a second attachment to this bug, that would be great :-)
Flags: needinfo?(emorley)
(Assignee)

Comment 9

4 years ago
Created attachment 8527109 [details] [review]
Bug 823616 - Create a template for TreeStatus logs; r=catlee
Attachment #8527109 - Flags: review?(catlee)
Comment on attachment 8527109 [details] [review]
Bug 823616 - Create a template for TreeStatus logs; r=catlee

merged upstream as https://github.com/mozilla/treestatus/commit/ae1c22ac018c61e915eced0e0eb4ddf0fedabc58

thanks!
Attachment #8527109 - Flags: review?(catlee) → review+
(Reporter)

Updated

4 years ago
Depends on: 1110150
(Reporter)

Comment 11

4 years ago
In production - thank you for the patches :-)
(Reporter)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Product: Tree Management → Release Engineering
You need to log in before you can comment on or make changes to this bug.