823633 - Remove intermediate page for persona/browserID login

Status: RESOLVED INVALID

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

At the moment to sign in you have to:
1) Click 'login'
2) Wait for intermediate page to load (https://treestatus.mozilla.org/login)
3) Click 'sign in'
4) Complete the usual persona/browserID popup sign-in form
5) Wait for https://treestatus.mozilla.org/ to reload

It would be good if we could miss out steps 2+3 - and implement dynamically, in a way similar to MDN.

Comment 1

[Ed Morley [:emorley]]

Ryan/Wes/Tomcat - one of you up for taking this? :-)

This bug has been annoying me for a while - just at the point at which you want to close trees in a hurry, there are several unnecessary pop-up windows, extra steps and messing about.

The code is at:
https://github.com/mozilla/treestatus

For setting up a testing environment, see README in the repo.

We're using a Persona plugin (repoze.who.plugins.browserid ; see imported libraries: https://github.com/mozilla/treestatus/tree/master/requirements) - we may be better off switching to another plugin. The main requirement is to improve the UX, so signing in is as few clicks as possible, like MDN.

Any questions ask me (or catlee, since he wrote treestatus so knows more about it than myself) :-)

Comment 2

[Carsten Book [:Tomcat]]

will take a look :)

Comment 3

[Ed Morley [:emorley]]

(In reply to Carsten Book [:Tomcat] from comment #2)
> will take a look :)

Tomcat, are you still interested in doing this, or should I make it a good first bug? (just seeing if I can make a few, given dburns email :-))

Comment 4

[Carsten Book [:Tomcat]]

yeah this should make a great first bug, thanks for the suggestion ed

Comment 5

[Abhishek]

I am interested in it can you tell me how should I continue since it is my first bug can you give little more info about this

Comment 6

[Ed Morley [:emorley]]

(In reply to Abhishek from comment #5)
> I am interested in it can you tell me how should I continue since it is my
> first bug can you give little more info about this

Hi - great to hear you are interested in taking a look at this!

If you have a look at comment 1, there is a link to the git repository, which you'll need to clone, and inside that there is a README, which explains how to get a local instance running. After that, look back at comment 0 and comment 1 for the rough overview of what we're trying to change here - and if you have any questions, just ask back here :-)

Comment 7

[ram_0323]

i'm intrested in it

Comment 8

[Ed Morley [:emorley]]

Great - please see comment 6 for how to get started :-)

Comment 9

[ram_0323]

how are you doing redirection to login page from index one??

Comment 10

[Ed Morley [:emorley]]

(In reply to ram_0323 from comment #9)
> how are you doing redirection to login page from index one??

Top right of the https://treestatus.mozilla.org/ pages is a "login" button that links to:
https://treestatus.mozilla.org/login

Comment 11

[Sagar Pandey]

Ed : Is this still available to take ??

Comment 12

[Sagar Pandey]

Ed : Is this still available to take ??

Comment 13

[Ed Morley [:emorley]]

Yes it is :-)

Comment 14

[Sagar Pandey]

Thanks Ed . I am on it.

Comment 15

[Sagar Pandey]

Ed: How should I go about implementing the skipping the steps 2+3 ? I have already setup the environment.

Comment 16

[Sambuddha Basu [:sambuddhabasu1]]

I want to work on this bug. Can someone assign it to me?

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Ugh, didn't read the comments closely when I was asked to assign the bug in IRC.

Comment 18

[Sagar Pandey]

Is it assigned to two people at once ???

Comment 19

[Ed Morley [:emorley]]

(In reply to Sambuddha Basu from comment #16)
> I want to work on this bug. Can someone assign it to me?

I'm sorry Sagar was already working on this bug (see comment 14 and comment 15).

(In reply to Sagar Pandey from comment #18)
> Is it assigned to two people at once ???

Just you :-)

Comment 20

[Sagar Pandey]

Ed : Thanks . What about Comment 15 ?

Comment 21

[Ed Morley [:emorley]]

I'm not that familiar with the browser-id plugin being used, however I would start by:
1) Finding out where the upstream is for the current plugin. I believe the name is repoze.who.plugins.browserid which led me to https://github.com/mozilla-services/repoze.who.plugins.browserid however I'm struggling to match this against the files in https://github.com/mozilla/treestatus-lib .
2) Checking we are on the most up to date version of that plugin.
3) Seeing if the plugin either has another mode for being used inline, or whether it's just that we're mis-using it at present.
4) Failing that, ask around to find out what other python browserid libraries are available.

Comment 22

[Ed Morley [:emorley]]

I think #4 might be the best bet personally - given that browser-id is used all over the place (MDN, mozillians.org) there must be more modern libraries knocking around.

Comment 23

[Sagar Pandey]

Thanks for all the suggestions Ed.  I am on it .

Comment 24

[Sagar Pandey]

The Kuma uses a Persona Login Service that delivers pretty much all what we need . Would it make sense to replace the Login button with the Persona Sign In Service ?

Comment 25

[Ed Morley [:emorley]]

Possible, I unfortunately don't know much about Kuma.

I've also seen:
https://github.com/garbados/flask-browserid

...which may be worth a look.

Comment 26

[Lalit M [:darklord]]

I'm interested to work on this bug.Can I get it assigned?

Comment 27

[Ed Morley [:emorley]]

I'm not sure if Sagar is still working on this or not. You're welcome to take a look at it in the meantime, if you like? :-)

I'm unassigning myself as mentor, since I don't really know browserid/flask too well & Treeherder needs more focus at the moment. However if I see any questions I know the answer to, I'll try and help :-)

Comment 28

[Phil Ringnalda (:philor)]

Persona is dead, long live http auth.