823643 - deploy train-2012.11.23.5 to stage

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[John Morrison [:jrgm]]

Please deploy train-2012.11.23.5 to stage. The commit sha is eafb1fec0 and we should stay at 'locale svn r111604' for strings.

Comment 1

[Gene Wood [:gene]]

staging updated with browserid-server-0.2012.11.23-5.el6_111604.x86_64.rpm

still working on l10n and clientN due to an mrepo outage today : https://bugzilla.mozilla.org/show_bug.cgi?id=822799

Comment 2

[John Morrison [:jrgm]]

Thanks Gene. (Sorry, was in meetings ugh, 3:30 till now).

Comment 3

[Gene Wood [:gene]]

l10n and clientN updated.

Reason for the failure is that this is the first time I've done a downgrade (12.07 to 11.23) in staging and my process failed.

Comment 4

[John Morrison [:jrgm]]

I used stomlinson's ./scripts/capture_deployed_resources.js to pull in
resources from production and logging. I wrote a quick and dirty script to
s/persona.org/anosrep.org/, extract all the https?:// urls, and the below are
the js/css urls that changed (the fonts and images did not change of course,
and e.g., html5shim.js was explicitly left unchanged).

- https://static.login.anosrep.org/v/23315a7dc9/production/browserid.css
+ https://static.login.anosrep.org/v/85ce3f9526/production/browserid.css

- https://static.login.anosrep.org/v/40ad3f3873/production/en/browserid.js
+ https://static.login.anosrep.org/v/520c400846/production/en/browserid.js

- https://static.login.anosrep.org/v/459eb7d5fd/production/communication_iframe.js
+ https://static.login.anosrep.org/v/ebfdd20a56/production/communication_iframe.js

- https://static.login.anosrep.org/v/bb639e5179/production/authenticate_with_primary.js
+ https://static.login.anosrep.org/v/787d0f493d/production/authenticate_with_primary.js

- https://static.login.anosrep.org/v/e887666eea/production/en/dialog.js
+ https://static.login.anosrep.org/v/4da163f37c/production/en/dialog.js

- https://static.login.anosrep.org/v/a28a485aba/production/dialog.css
+ https://static.login.anosrep.org/v/8d48fda88e/production/dialog.css

- https://static.login.anosrep.org/v/844b6f3f18/production/ie8_dialog.css
+ https://static.login.anosrep.org/v/b714baa72b/production/ie8_dialog.css

- https://static.login.anosrep.org/v/b1129a1364/production/ie8_main.css
+ https://static.login.anosrep.org/v/fe9ca30ed1/production/ie8_main.css

In starting to compare the '\.js$|\.css$' files for urls that hadn't changed, I noticed one oddity. 'https://static.login.anosrep.org/v/4da163f37c/production/en/dialog.js' has a reference to 'https://login.anosrep.org/v/1e78e62723/dialog/css/style.css'. That appears to come from here (?): resources/static/dialog/views/test_template_cachify.ejs from looking at unminified en/dialog.js. Now the resources/static/dialog/css/style.css shows a change on Oct 5th, and then on Nov 27th and Nov 30th, so appears to be outside the window (and appears to be for testing?). I'll file this as a github issue to get a blessing on this.

Comment 5

[John Morrison [:jrgm]]

- curl -s https://login.anosrep.org/ver.txt x 100 runs->
eafb1fe Merge pull request #2889 from mozilla/2012.11.23-hotfix-issue2863
locale svn r111604

- curl -s https://login.anosrep.org/sign_in | grep 'Current' x 100 runs ->
   - Current Commit: https://github.com/mozilla/browserid/commit/eafb1fe

- $ for i in {web,sweb,sign}{1,2,3}; do ssh $i 'node --version'; done | sort | uniq -c
    9 v0.8.12

- `sudo svstat /service/browserid*` on all of stage and,
    for i in {web,sweb,sign}{1,2,3}; do
      echo @@ $i @@
      ssh $i "ps -eo pid,lstart,bsdtime,pcpu,pri,rsz,vsz,command | grep 'node bin/' | grep -v grep" 2>/dev/null
    done
  shows the processes restarted and not flapping

- ran tests locally on osx, with all passing. Travis on ubuntu 12.04 32-bit agrees https://travis-ci.org/mozilla/browserid/builds/3763441

- started a small 250K load test and gave that a couple of hours; no problems (which in this case, which for client-side js/css only change, there cannot be, but just for completeness..). The {browserid,dbwriter,keysigner,router,static,verifier} processes are steady-state on RSS (bouncing between 27M and 70M as GC happens).

- completed basic functional flow on firefox/osx and spot check ie8/winxp with no problems.

- ran a script to load /sign_in dialog and main site with multiple languages with no known issues.

I'm signing off on this build to go to production (bug 823396) conditional on getting the answer on https://github.com/mozilla/browserid/issues/2896.