Created attachment 694533 [details] Firefox Beta 18.0 Beta 5 (Screenshot) See screenshot. https://hg.mozilla.org/mozilla-central/file/d81af339bb7a/mobile/android/base/background/announcements/AnnouncementPresenter.java#l53 Care enough for Beta?
This looks very broken. I imagine this is as simple as switching an image (which we are already using elsewhere), so let's please try to get it in.
Ian, which release should have the updated logo?
I know snorp was using it for the updater. I'm not sure what release (other than Nightly) that is in right now.
Created attachment 697280 [details] [diff] [review] Use updater icon instead of launcher icon for announcements
Looks like this missed the 18 cutoff date.
Comment on attachment 697280 [details] [diff] [review] Use updater icon instead of launcher icon for announcements We should push it to aurora ASAP though
brian request approval to uplift to 19
Comment on attachment 697280 [details] [diff] [review] Use updater icon instead of launcher icon for announcements [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 793053 User impact if declined: notification icon looks bad (see screenshot) Testing completed (on m-c, etc.): m-i Risk to taking this patch (and alternatives if risky): low risk String or UUID changes made by this patch: none
Hey y'all, this code is managed in git at https://github.com/mozilla-services/android-sync. I'll apply this patch to the git repository and everything will be fine, but please keep rnewman or me in the loop when Android services code is changing. Thanks!
(In reply to Nick Alexander :nalexander from comment #11) > Backported to git: > > https://github.com/mozilla-services/android-sync/commit/ > d9f3b7c73bfb055214f063c13c7dbf79680c6c12 Spoke to soon -- needed script updates to ignore the new .png file. Try: https://github.com/mozilla-services/android-sync/commit/fd74340cbdfcd0a3abbe4d86aafe170519b70516
Aaron: please make sure to file Announcements bugs in the right component so we can see them. Thanks! Thanks for the backport, Nick.
This was originally supposed to ship with 18, but missed the deadline. It's a trivial change for UI polish; see notification icon in the screenshot for what it looks like without this patch applied. Very low risk.
AFAIK, no way to verify this until an announcement goes out (I trust this simple enough patch though).
It's trivial to write a restartless add-on that calls into the Java code, FWIW.
If we do spin an 18.0.1, we'd consider taking this trivial fix. Engineering would have to help QA verify the fix though (or verify themselves). Tracking.
verified against stage. This is now using the same icon as the update notification