823707 - "JavaScript Error: "NO SETTINGS PERMISSION FOR: app://video.gaiamobile.org"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Noticed when opening settings app.

I don't know if this is a problem.  bb? to triage what might be affected.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I noticed it for opening the video app...

12-20 15:55:50.271: E/GeckoConsole(778): [JavaScript Warning: "Expected color but found 'top'.  Error in parsing value for 'background'.  Declaration dropped." {file: "app://video.gaiamobile.org/style/video.css" line: 16}]
12-20 15:55:50.421: E/GeckoConsole(778): [JavaScript Error: "NO SETTINGS PERMISSION FOR: app://video.gaiamobile.org
12-20 15:55:50.421: E/GeckoConsole(778): " {file: "jar:file:///system/b2g/omni.ja!/components/SettingsManager.js" line: 345}]

I wonder if it's related to : bug 816556

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, what are the steps to repro and the user impact? please renom if user impact is great. thanks

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Open the video app

Potential impact
 I filed this to ask triagers what the impact might be.  Let's try again.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

To be clearer, someone who knows the video app should reply about why it needs settings permissions, and what might break if the video app can't access settings.

I hope this is just dead code that's failing.

Comment 5

[David Scravaglieri [:scravag]]

Dale, David, any idea if this is a problem ?

Comment 6

[Dale Harvey (:daleharvey)]

The video app doesnt have use or ask for settings permissions

$ grep -r "setting" ./apps/video/
''

I was always confused at why this error came up, can investigate

Comment 7

[Dale Harvey (:daleharvey)]

So this is likely due to audio-channel-content requiring a permission read, also due to https://bugzilla.mozilla.org/show_bug.cgi?id=780953 evey app requires a read settings permissions to be properly localised.

So the 2 issues are that is likely breaks mozAudioChannel and cannot switch languages, both of which were blocking issues, so would suggest this blocks too.

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Add readonly settings permissions to video for l10n and audioChannel

Comment 9

[David Flanagan [:djf]]

Comment on attachment 694883 [details] [diff] [review]
Add readonly settings permissions to video for l10n and audioChannel

I love one line reviews!

Comment 10

[David Flanagan [:djf]]

Comment on attachment 694883 [details] [diff] [review]
Add readonly settings permissions to video for l10n and audioChannel

Oops, wait!

Don't merge this without adding a comma at the end of the new line.
r+ only if you add the comma and test the patch!

Comment 11

[Dale Harvey (:daleharvey)]

fixed

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, P3, C3 - blocking per comment 7