823730 - Update make target for xpcshell-tests-remote

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

There's good advice from :ted at https://bugzilla.mozilla.org/show_bug.cgi?id=821424#c2. Let's apply that to the xpcshell-tests-remote make target also.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: simplify xpcshell-tests-remote make targets

These targets should work just the same -- just tidying up.

Again, no rush.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 694671 [details] [diff] [review]
simplify xpcshell-tests-remote make targets

Review of attachment 694671 [details] [diff] [review]:
-----------------------------------------------------------------

this looks fine, but why did we change from having the -I flags?  Also should we update xpcshell_b2g?

Comment 3

[Geoff Brown [:gbrown]]

(In reply to Joel Maher (:jmaher) from comment #2)
> this looks fine, but why did we change from having the -I flags?  

:ted said: "You shouldn't need to use pythonpath here, these things should all be in the Python virtualenv nowadays. Drop pythonpath.py and the -I bits."

> Also should we update xpcshell_b2g?

We can probably drop pythonpath from xpcshell_b2g also...but I'm not as comfortable changing b2g code. Also, we use pythonpath for xpcshell-tests and in a few other places...again, I'm not as sure about the implications of removing it there.

I'll land this and spin off another bug for the other cases: bug 824047.

Comment 4

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb8afdb2e47

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/2cb8afdb2e47