Closed Bug 823730 Opened 7 years ago Closed 7 years ago

Update make target for xpcshell-tests-remote

Categories

(Firefox for Android :: General, defect)

x86
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

There's good advice from :ted at https://bugzilla.mozilla.org/show_bug.cgi?id=821424#c2. Let's apply that to the xpcshell-tests-remote make target also.
These targets should work just the same -- just tidying up.

Again, no rush.
Attachment #694671 - Flags: review?(jmaher)
Comment on attachment 694671 [details] [diff] [review]
simplify xpcshell-tests-remote make targets

Review of attachment 694671 [details] [diff] [review]:
-----------------------------------------------------------------

this looks fine, but why did we change from having the -I flags?  Also should we update xpcshell_b2g?
Attachment #694671 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #2)
> this looks fine, but why did we change from having the -I flags?  

:ted said: "You shouldn't need to use pythonpath here, these things should all be in the Python virtualenv nowadays. Drop pythonpath.py and the -I bits."

> Also should we update xpcshell_b2g?

We can probably drop pythonpath from xpcshell_b2g also...but I'm not as comfortable changing b2g code. Also, we use pythonpath for xpcshell-tests and in a few other places...again, I'm not as sure about the implications of removing it there.

I'll land this and spin off another bug for the other cases: bug 824047.
https://hg.mozilla.org/mozilla-central/rev/2cb8afdb2e47
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.