823733 - Rewrite save logic in revision form to be aware of inline section editing

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[John Karahalis [:openjck]]

This is a subtask of bug 772898.

Based on what we discover in bug 823731 (and potentially other research tasks) we need to actually fix the section editing table of contents problem.

Comment 1

[Luke Crouch [:groovecoder]]

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=823731#c1 we should re-enable section editing, probably behind a waffle flag.

Comment 2

[John Karahalis [:openjck]]

This is a subtask of bug 772898.

In our meeting yesterday, we discussed that the TOC is probably being removed after section editing because the logic that saves revisions does not handle this case properly and assumes that the TOC has been intentionally removed when a section edit happens. James (cc'd here) can answer any additional questions about this.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/69b1c1036df3f8cae3f36d6d56547d92c61e3da2
Fix bug 823733: Rework RevisionForm save logic for section editing.

This adds a separate code path (largely because I suspect we're going
to find more things that need to be different in section edits) for
saving a section edit, and ensures that the existing show_toc and
review_tags are preserved (since they're not submitted in a section
edit).

https://github.com/mozilla/kuma/commit/610f0d15cdc9153da5749a5f8db4029358cb9c9e
Merge pull request #800 from ubernostrum/section-edit-toc

Fix bug 823733: Rework RevisionForm save logic for section editing.

Comment 5

[raymond [:retornam] (inactive)]

verified fixed https://developer.allizom.org/en-US/docs/HTML/HTML5