823785 - [B2G][Settings][Battery] Cancel button is missing in the Turn On Automatically drop down box under Settings->Battery

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Cody Roesch [:croesch]]

Attachment: Battery Drop Down Menu.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121128204232

Steps to reproduce:

1. Launch Build 20121217070202 version 18.0
2. Go to settings
3. Go to Battery
4. Tap on the Turn On Automatically drop down menu which brings up a new window.
5. Notice that under all the options is a large OK button.
6. Notice there is no Cancel button present.

Repro 100%


Actual results:

There seems to be a missing Cancel button in the battery drop down menu.


Expected results:

Test case 1406 and Test Case 1407 describe this page having a Cancel button. In fact, 1407 specifically calls out to back out of the drop down menu using this Cancel button.

Comment 1

[Cody Roesch [:croesch]]

Bug still present in build 20130104070203 while running Test Pass 2.

Comment 2

[amiller]

UCID: set-083
https://moztrap.mozilla.org/results/case/62781/

Comment 3

[Sam Shipley]

Issue of cancel button not present on the battery menu still repros on Unagi device.

Build ID: 20130221070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/effe37a77f18
Gaia: bb633c6f2deb829b2f3d5b9e7bac7fa24467d02a

Comment 4

[John Hammink]

This requirement/testcase is base on old wireframes, etc.  Needs some investigation to ensure that this requirement is valid.

Comment 5

[amiller]

UCID: set-083
As a user I want to be able to select the threshold of battery left  after which "Power Save Mode" kicks in, so that I can consume less power when the battery is low.

Comment 6

[John Hammink]

UCID set-083 is in scope for v 1.0

Checked most recently on 
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/99680a32f297
Gaia   de3e5b9205e6cb1a6bd0858a98d159272ad96d11
BuildID 20130312070202
Version 18.0

The requirement itself says nothing at all about specifically a cancel button; and in fact, no cancel button is needed (simply select "ok" without changing the option has same result).   Let's fix the testcase.

Comment 7

[Cody Roesch [:croesch]]

Inari build: 20130416070200
Kernel: Feb 21st
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia   c883af5ecd0998f78d9aaa4c2337c842e1dbb5a0

UCID
https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=1407

In the above build for the Inari device, there is no Cancel button in the Battery drop down list.

Comment 8

[Jeni]

Issue repros on 
Inari Build ID: 20130515070208
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d06cfe7d67c2
Gaia: 0ddb515f15cbc6b74fc2742b7599d6ae74c6413f

There is no cancel button in the battery drop down list.

Comment 9

[John Hammink]

set-083: As a user I want to be able to select the threshold of battery left  after which "Power Save Mode" kicks in, so that I can consume less power when the battery is low.

However no spec here as for OK, and Cancel.  Presumably we don't need both, but checking with UX.

Comment 10

[Stephany Wilkes]

Adding Francis: Do we have a pointer to specs for John?

Comment 11

[Francis Djabri [:djabber]]

There are no specs as far as I'm aware, but the general patterns for Value Selectors are available here:

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/UX/Building_blocks/Value_selector

These patterns show that the Single Value selector should have a Cancel button, not an OK button. Selecting a new option should be all that it takes for the user to confirm the new selection without having to press "OK". 

I've noticed that the single value selector hasn't been implemented correctly in a number of places. Ideally, this component should have the correct design implemented as standard - can we raise a bug on the component itself?

Comment 12

[Darren]

Not sure if this is even an issue still, since it might be considered as the single value selector.

Please let me know.

Comment 13

[[e-mail]]

need system wide UI change

Comment 14

[BMO Automation]

Firefox OS is not being worked on